chore: bump Go to 1.27 and golangci-lint to v2.13.2 (#50)

* chore: bump Go to 1.27 and golangci-lint to v2.13.2

Raise the module Go version to 1.27 and update the Makefile linter
pin to v2.13.2 (Go 1.27 support).

Fixes #49

* chore: migrate .golangci.yml to v2 config format

Required for golangci-lint v2.13.x after the Makefile pin bump.

* chore: fix golangci-lint v2 install and address new lint findings

The official install.sh checksum lookup matches *.tar.gz.sbom.json on
v2.13.x, so install the release tarball directly. Also satisfy
staticcheck QF1008 and keep noisy test-only linters excluded.

* chore: shrink .golangci.yml under 100 lines (keep strength)

* chore: simplify lint to a one-line go run toolchain invoke

* chore: simplify lint config and Makefile for Go 1.27

Use golangci-lint via go tool with a dedicated tools.mod so the
package go.mod stays dependency-free. Shrink .golangci.yml with
default: all plus a short disable list.

* chore: add tools.mod for go tool golangci-lint

Keep package go.mod dependency-free while pinning the linter via the
Go 1.24 tool directive in a dedicated tools.mod.

* Simplify lint config and Makefile

Shrink .golangci.yml by using default: all instead of an explicit
enable list, keeping the existing thresholds. Run golangci-lint with
go run so the lint target is one line and go.mod stays dependency-free.

Author: MrBeldum

.golangci.yml

@@ -1,198 +1,88 @@
-run:
-  timeout: 1m
-
-linters-settings:
-  errcheck:
-    # report about not checking of errors in type assetions: `a := b.(MyStruct)`;
-    # default is false: such cases aren't reported by default.
-    check-type-assertions: true
-
-    # report about assignment of errors to blank identifier: `num, _ := strconv.Atoi(numStr)`;
-    # default is false: such cases aren't reported by default.
-    check-blank: false
-
-    # [deprecated] comma-separated list of pairs of the form pkg:regex
-    # the regex is used to ignore names within pkg. (default "fmt:.*").
-    # see https://github.com/kisielk/errcheck#the-deprecated-method for details
-    # ignore: fmt:.*,io/ioutil:^Read.*
-
-    # path to a file containing a list of functions to exclude from checking
-    # see https://github.com/kisielk/errcheck#excluding-functions for details
-    # exclude: /path/to/file.txt
-
-  funlen:
-    lines: 50
-    statements: 40
-
-  govet:
-    # report about shadowed variables
-    shadow: true
-
-    # enable or disable analyzers by name
-    # enable:
-    #   - atomicalign
-    enable-all: true
-    disable:
-      - fieldalignment
-    # disable-all: false
-  revive:
-    # minimal confidence for issues, default is 0.8
-    min-confidence: 0.8
-  gofmt:
-    # simplify code: gofmt with `-s` option, true by default
-    simplify: true
-  goimports:
-    # put imports beginning with prefix after 3rd-party packages;
-    # it's a comma-separated list of prefixes
-    local-prefixes: github.com/kinbiko/bugsnag
-  gocyclo:
-    # minimal code complexity to report, 30 by default (but we recommend 10-20)
-    # This check is set to an unreasonably low number by most developers'
-    # standards to track the code standard over time
-    min-complexity: 10
-  gocognit:
-    # minimal code complexity to report, 30 by default (but we recommend 10-20)
-    # This check is a more useful cyclomatic complexity called cognitive complexity,
-    # where nested if/for is weighted more, and only one point regardless of
-    # cases in a switch.
-    min-complexity: 11
-  dupl:
-    # tokens count to trigger issue, 150 by default
-    threshold: 100
-  goconst:
-    # minimal length of string constant, 3 by default
-    min-len: 10
-    # minimal occurrences count to trigger, 3 by default
-    min-occurrences: 3
-
-    # packages-with-error-messages:
-    # specify an error message to output when a blacklisted package is used
-    # github.com/sirupsen/logrus: "logging is allowed only by logutils.Log"
-  misspell:
-    # Correct spellings using locale preferences for US or UK.
-    # Default is to use a neutral variety of English.
-    # Setting locale to US will correct the British spelling of 'colour' to 'color'.
-    locale: US
-    # ignore-words:
-    #   - someword
-  lll:
-    # max line length, lines longer will be reported. Default is 120.
-    # '\t' is counted as 1 character by default, and can be changed with the tab-width option
-    line-length: 165
-    # tab width in spaces. Default to 1.
-    tab-width: 4
-  unused:
-    # treat code as a program (not a library) and report unused exported identifiers; default is false.
-    # XXX: if you enable this setting, unused will report a lot of false-positives in text editors:
-    # if it's called for subdir of a project it can't find funcs usages. All text editor integrations
-    # with golangci-lint call it on a directory with the changed file.
-    check-exported: false
-  unparam:
-    # Inspect exported functions, default is false. Set to true if no external program/library imports your code.
-    # XXX: if you enable this setting, unparam will report a lot of false-positives in text editors:
-    # if it's called for subdir of a project it can't find external interfaces. All text editor integrations
-    # with golangci-lint call it on a directory with the changed file.
-    check-exported: true
-  nakedret:
-    # make an issue if func has more lines of code than this setting and it has naked returns; default is 30
-    # Naked returns can go plop itself
-    max-func-lines: 0
-  prealloc:
-    # XXX: we don't recommend using this linter before doing performance profiling.
-    # For most programs usage of prealloc will be a premature optimization.
-
-    # Report preallocation suggestions only on simple loops that have no returns/breaks/continues/gotos in them.
-    # True by default.
-    simple: true
-    range-loops: true # Report preallocation suggestions on range loops, true by default
-    for-loops: false # Report preallocation suggestions on for loops, false by default
-  gocritic:
-    # Which checks should be enabled; can't be combined with 'disabled-checks';
-    # See https://go-critic.github.io/overview#checks-overview
-    # To check which checks are enabled run `GL_DEBUG=gocritic golangci-lint run`
-    # By default list of stable checks is used.
-    # enabled-checks:
-    #   - badCond
-
-    # Which checks should be disabled; can't be combined with 'enabled-checks'; default is empty
-    # disabled-checks:
-
-    # Enable multiple checks by tags, run `GL_DEBUG=gocritic golangci-lint run` to see all tags and checks.
-    # Empty list by default. See https://github.com/go-critic/go-critic#usage -> section "Tags".
-    enabled-tags:
-      - diagnostic
-      - style
-      - performance
-
-    settings: # settings passed to gocritic
-      captLocal: # must be valid enabled check name
-        paramsOnly: true
-      rangeValCopy:
-        sizeThreshold: 64
-  godox:
-    # report any comments starting with keywords, this is useful for TODO or FIXME comments that
-    # might be left in the code accidentally and should be resolved before merging
-    keywords: # default keywords are TODO, BUG, and FIXME, these can be overwritten by this setting
-      - TODO
-      - FIXME
-  dogsled:
-    # checks assignments with too many blank identifiers; default is 2
-    max-blank-identifiers: 2
-
-  whitespace:
-    multi-if: false # Enforces newlines (or comments) after every multi-line if statement
-    multi-func: false # Enforces newlines (or comments) after every multi-line function signature
-
+version: "2"
 linters:
+  default: all
   disable:
-    - wsl
+    - depguard
+    - exhaustruct # replaced by exhaustruct_v5
     - godot
+    - gomodguard # replaced by gomodguard_v2
+    - modernize
     - nlreturn
-
-    - depguard
-
-    - gci # This conflicts with goimports
-    - varnamelen # This has too many false positives around indexes etc to be useful
-  presets:
-    - bugs
-    - complexity
-    - format
-    - performance
-    - style
-    - unused
-  fast: false
-
+    - noinlineerr
+    - testableexamples
+    - varnamelen
+    - wsl
+    - wsl_v5
+  settings:
+    dupl:
+      threshold: 100
+    errcheck:
+      check-type-assertions: true
+    funlen:
+      lines: 50
+      statements: 40
+    gocognit:
+      min-complexity: 11
+    goconst:
+      min-len: 10
+      min-occurrences: 3
+    gocritic:
+      enabled-tags:
+        - diagnostic
+        - style
+        - performance
+      settings:
+        captLocal:
+          paramsOnly: true
+        rangeValCopy:
+          sizeThreshold: 64
+    gocyclo:
+      min-complexity: 10
+    govet:
+      enable-all: true
+      disable:
+        - fieldalignment
+    lll:
+      line-length: 165
+      tab-width: 4
+    misspell:
+      locale: US
+    nakedret:
+      max-func-lines: 0
+    unparam:
+      check-exported: true
+  exclusions:
+    rules:
+      - path: _test\.go
+        linters:
+          - cyclop
+          - dupl
+          - errcheck
+          - errchkjson
+          - forbidigo
+          - funlen
+          - gocognit
+          - goconst
+          - gocyclo
+          - gosmopolitan
+          - lll
+          - maintidx
+          - mnd
+          - paralleltest
+          - staticcheck
+          - testpackage
+          - varnamelen
+      - path: \.go
+        linters:
+          - err113
 issues:
-  # Excluding configuration per-path, per-linter, per-text and per-source
-  exclude-rules:
-    # Exclude some linters from running on tests files.
-    - path: _test\.go
-      linters:
-        - cyclop
-        - dupl
-        - errcheck
-        - errchkjson
-        - exhaustivestruct
-        - forbidigo
-        - funlen
-        - gocognit
-        - gocyclo
-        - gomnd
-        - lll
-        - stylecheck
-        - testpackage
-        - varnamelen
-        - maintidx
-    - path: \.go
-      linters:
-        - err113
-
-  # Independently from option `exclude` we use default exclude patterns,
-  # it can be disabled by this option. To list all
-  # excluded by default patterns execute `golangci-lint run --help`.
-  # Default value for this option is true.
-  exclude-use-default: false
-  # Maximum issues count per one linter. Set to 0 to disable. Default is 50.
   max-issues-per-linter: 0
-  # Maximum count of issues with the same text. Set to 0 to disable. Default is 3.
   max-same-issues: 0
+formatters:
+  enable:
+    - gofumpt
+    - goimports
+  settings:
+    goimports:
+      local-prefixes:
+        - github.com/kinbiko/bugsnag

Makefile

@@ -1,5 +1,3 @@
-LINTER_VERSION := v1.61.0
-
 .PHONY: check
 check: lint test
 
@@ -8,17 +6,13 @@ get-deps:
 	go get -v -t -d ./...
 
 .PHONY: lint
-lint: ./bin/linter
-	./bin/linter run ./...
+lint:
+	go run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.13.2 run ./...
 
 .PHONY: test
 test:
 	go test -race -count=1 ./...
 
 .PHONY: coverage
 coverage:
-	go test -race -v -coverprofile=profile.cov -covermode=atomic ./...
-
-bin/linter: Makefile
-	curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b ./bin $(LINTER_VERSION)
-	mv ./bin/golangci-lint ./bin/linter
+	go test -race -v -coverprofile=profile.cov -covermode=atomic ./...

array.go

@@ -7,7 +7,7 @@ import (
 )
 
 func (a *Asserter) checkArray(path string, act, exp []interface{}) {
-	a.tt.Helper()
+	a.Helper()
 	if len(exp) > 0 && exp[0] == "<<UNORDERED>>" {
 		a.checkArrayUnordered(path, act, exp[1:])
 	} else {
@@ -17,14 +17,14 @@ func (a *Asserter) checkArray(path string, act, exp []interface{}) {
 
 //nolint:gocognit,gocyclo,cyclop // function is actually still readable
 func (a *Asserter) checkArrayUnordered(path string, act, exp []interface{}) {
-	a.tt.Helper()
+	a.Helper()
 	if len(act) != len(exp) {
-		a.tt.Errorf("length of arrays at '%s' were different. Expected array to be of length %d, but contained %d element(s)", path, len(exp), len(act))
+		a.Errorf("length of arrays at '%s' were different. Expected array to be of length %d, but contained %d element(s)", path, len(exp), len(act))
 		serializedAct, serializedExp := serialize(act), serialize(exp)
 		if len(serializedAct+serializedExp) < maxMsgCharCount {
-			a.tt.Errorf("actual JSON at '%s' was: %+v, but expected JSON was: %+v, potentially in a different order", path, serializedAct, serializedExp)
+			a.Errorf("actual JSON at '%s' was: %+v, but expected JSON was: %+v, potentially in a different order", path, serializedAct, serializedExp)
 		} else {
-			a.tt.Errorf("actual JSON at '%s' was:\n%+v\nbut expected JSON was:\n%+v,\npotentially in a different order", path, serializedAct, serializedExp)
+			a.Errorf("actual JSON at '%s' was:\n%+v\nbut expected JSON was:\n%+v,\npotentially in a different order", path, serializedAct, serializedExp)
 		}
 		return
 	}
@@ -39,9 +39,9 @@ func (a *Asserter) checkArrayUnordered(path string, act, exp []interface{}) {
 		if !found {
 			serializedEl := serialize(actEl)
 			if len(serializedEl) < maxMsgCharCount {
-				a.tt.Errorf("actual JSON at '%s[%d]' contained an unexpected element: %s", path, i, serializedEl)
+				a.Errorf("actual JSON at '%s[%d]' contained an unexpected element: %s", path, i, serializedEl)
 			} else {
-				a.tt.Errorf("actual JSON at '%s[%d]' contained an unexpected element:\n%s", path, i, serializedEl)
+				a.Errorf("actual JSON at '%s[%d]' contained an unexpected element:\n%s", path, i, serializedEl)
 			}
 		}
 	}
@@ -54,23 +54,23 @@ func (a *Asserter) checkArrayUnordered(path string, act, exp []interface{}) {
 		if !found {
 			serializedEl := serialize(expEl)
 			if len(serializedEl) < maxMsgCharCount {
-				a.tt.Errorf("expected JSON at '%s[%d]': %s was missing from actual payload", path, i, serializedEl)
+				a.Errorf("expected JSON at '%s[%d]': %s was missing from actual payload", path, i, serializedEl)
 			} else {
-				a.tt.Errorf("expected JSON at '%s[%d]':\n%s\nwas missing from actual payload", path, i, serializedEl)
+				a.Errorf("expected JSON at '%s[%d]':\n%s\nwas missing from actual payload", path, i, serializedEl)
 			}
 		}
 	}
 }
 
 func (a *Asserter) checkArrayOrdered(path string, act, exp []interface{}) {
-	a.tt.Helper()
+	a.Helper()
 	if len(act) != len(exp) {
-		a.tt.Errorf("length of arrays at '%s' were different. Expected array to be of length %d, but contained %d element(s)", path, len(exp), len(act))
+		a.Errorf("length of arrays at '%s' were different. Expected array to be of length %d, but contained %d element(s)", path, len(exp), len(act))
 		serializedAct, serializedExp := serialize(act), serialize(exp)
 		if len(serializedAct+serializedExp) < maxMsgCharCount {
-			a.tt.Errorf("actual JSON at '%s' was: %+v, but expected JSON was: %+v", path, serializedAct, serializedExp)
+			a.Errorf("actual JSON at '%s' was: %+v, but expected JSON was: %+v", path, serializedAct, serializedExp)
 		} else {
-			a.tt.Errorf("actual JSON at '%s' was:\n%+v\nbut expected JSON was:\n%+v", path, serializedAct, serializedExp)
+			a.Errorf("actual JSON at '%s' was:\n%+v\nbut expected JSON was:\n%+v", path, serializedAct, serializedExp)
 		}
 		return
 	}

boolean.go

@@ -13,8 +13,8 @@ func extractBoolean(b string) (bool, error) {
 }
 
 func (a *Asserter) checkBoolean(path string, act, exp bool) {
-	a.tt.Helper()
+	a.Helper()
 	if act != exp {
-		a.tt.Errorf("expected boolean at '%s' to be %v but was %v", path, exp, act)
+		a.Errorf("expected boolean at '%s' to be %v but was %v", path, exp, act)
 	}
 }