Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak checking icons #2364

Open
silvenon opened this issue Oct 19, 2020 · 0 comments
Open

Tweak checking icons #2364

silvenon opened this issue Oct 19, 2020 · 0 comments

Comments

@silvenon
Copy link
Contributor

silvenon commented Oct 19, 2020 •
edited
Loading

Checking icons implemented in #2332 is awesome, but I missed three requirements when reviewing it:

  1. it should not run when required (which is why it runs on postinstall as well), only when run with node
    • this is tricky, I don't know what to do here other than create our own development CLI using a tool like yargs, as a separate private package
  2. it should only run in pre-commit and on CI
    • we should remove it from build
    • we should add it to test-ci, probably right at the beginning
  3. it should not have output, it's not necessary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@silvenon