Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agnoster Theme Prompt: Highlight color is same as background color #10

Open
fleischie opened this issue Jun 22, 2017 · 3 comments
Open

Comments

@fleischie
Copy link

First of all: Thank you for your work. It was the main reason I changed to using hyper full time. 🙇 😄

Description

The highlighting color of specific elements are the same as their background:
screen shot 2017-06-22 at 11 08 23

For reference this is the same content with highlighting everything:
screen shot 2017-06-22 at 11 08 29

This does not happen, if I disable the plugin:
screen shot 2017-06-22 at 11 30 09
screen shot 2017-06-22 at 11 30 13

I am going to write anything specific to styling and setup I know. If I miss something please let me know, then I'll update the issue description. 😄

Theme settings

module.exports = {
  config: {
    ...
    colors: {
      black: '#626262',
      red: '#ff8373',
      green: '#d4fb73',
      yellow: '#fffdc3',
      blue: '#a5d5fe',
      magenta: '#ff90fe',
      cyan: '#d1d1fe',
      white: '#f1f1f1',
      lightBlack: '#8f8f8f',
      lightRed: '#ffc4be',
      lightGreen: '#d6fcba',
      lightYellow: '#fffed5',
      lightBlue: '#c2e3ff',
      lightMagenta: '#ffb2fe',
      lightCyan: '#e6e7fe',
      lightWhite: '#ffffff'
    },

    pokemon: 'random',
    pokemonSyntax: 'dark',
    unibody: true,

    ...
  }
}

Environment

  • macOS 10.12.5
  • Hyper 1.3.3.1754 (from Hyper -> About)
  • zsh 5.3.1
  • zprezto (https://github.com/sorin-ionescu/prezto)
  • agnoster theme (bundled in prezto)
  • powerline patched fira code font
  • hyper-pokemon 0.2.0 (from npm version from inside ~/.hyper_plugins/node_modules/hyper-pokemon)
@klaudiosinani
Copy link
Owner

klaudiosinani commented Jun 24, 2017

Thank you so much for your kind words! Knowing that other people enjoy the project as much as we do it's the greatest reward there is 😄
Also, I am sorry for the delayed reply, we were trying to fix the issue on agnoster-like prompts and at the same time to prevent a possible side effect/break on pure/robbyrussell-like prompts. You can get the hotfix here! Just replace the content of the existing index.js in ~/hyper_plugins/node_modules/hyper-pokemon/index.js with the code inside of the fiddle and it should do the trick 😄
This is a temporary fix, until the new release is out, where we plan to polish even more the custom prompts color support and also try to introduce a 16 colors, full fledged color-scheme for each pokemon theme! Thank you for taking the time to initially report the issue, your report was perfect, and you are more than welcome to add anything new regarding the project!

@klaudiosinani klaudiosinani changed the title Highlight color is same as background color Agnoster Theme Prompt: Highlight color is same as background color Jun 24, 2017
@shimphillip
Copy link

@klaussinani

Looks like this issue is still open. I did try out your hotfix link but I am getting an error.

Screen Shot 2019-09-03 at 9 24 09 PM

Thank you for your hard work. This theme is seriously awesome!

@shimphillip
Copy link

Also there is a typo here.

~/hyper_plugins/node_modules/hyper-pokemon/index.js should be

~/.hyper_plugins/node_modules/hyper-pokemon/index.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants