Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for identity element is missing during verification #203

Open
Robloit opened this issue Feb 6, 2023 · 0 comments
Open

Check for identity element is missing during verification #203

Robloit opened this issue Feb 6, 2023 · 0 comments

Comments

@Robloit
Copy link

Robloit commented Feb 6, 2023

According to NIST and BSI, during signature verification, the calculated point after shamirs trick should be checked. If it is the identity element or a multiple of it, further evaluation should be aborted. This check is missing and should be included here:

micro-ecc/uECC.c

Line 1588 in b335ee8

For reference see these links:
NIST: https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.186-5.pdf (Section 6.4.2 Step 6)
BSI: https://www.bsi.bund.de/SharedDocs/Downloads/EN/BSI/Publications/TechGuidelines/TR03111/BSI-TR-03111_V-2-1_pdf.pdf?__blob=publicationFile&v=1 (Section 4.2.1.2 Step 4)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant