testsuite: Assert a test binary is non-empty

lucasdemarchi · lucasdemarchi · commit 3099e492a200 · 2025-01-06T10:23:17.000-06:00
Avoid issues like #269 by asserting the test binary is non-empty: Suggested-by: Emil Velikov <emil.l.velikov@gmail.com> Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>
diff --git a/testsuite/testsuite.c b/testsuite/testsuite.c
@@ -82,6 +82,9 @@ int test_init(const struct test *start, const struct test *stop, int argc,
 {
 	progname = argv[0];
 
+	/* An empty testsuite is not likely intended */
+	assert_return(start != stop, -EINVAL);
+
 	for (;;) {
 		int c, idx = 0;
 		c = getopt_long(argc, argv, options_short, options, &idx);

Original file line number	Diff line number	Diff line change
`@@ -82,6 +82,9 @@ int test_init(const struct test start, const struct test stop, int argc,`
`82`	`82`	`{`
`83`	`83`	`progname = argv[0];`
`84`	`84`
	`85`	`+ /* An empty testsuite is not likely intended */`
	`86`	`+ assert_return(start != stop, -EINVAL);`
	`87`	`+`
`85`	`88`	`for (;;) {`
`86`	`89`	`int c, idx = 0;`
`87`	`90`	`c = getopt_long(argc, argv, options_short, options, &idx);`