Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client blocking and request timeout #13

Open
xarg opened this issue Aug 9, 2022 · 1 comment
Open

Client blocking and request timeout #13

xarg opened this issue Aug 9, 2022 · 1 comment

Comments

@xarg
Copy link

xarg commented Aug 9, 2022

Seems your requests client doesn't have any timeout as well as it's running in a "blocking" operation which means that there's a chance to block some operation for a very long time your backends are slow for some reason.

Any chance to add a "timeout" param to the SDK. Optionally this identification runs in a thread similar to the Segment Python SDK?

The point is here is that I prefer to fail sending a notification from the app rather than cause a downtime due to your service slowdown. The "sync" mode still makes sense in a queue/consumer scenario where you want to have a synchronous failing situation to retry the sending.

@cjbell
Copy link
Contributor

cjbell commented Aug 25, 2022

hey @xarg – great question here. we can absolutely look at adding some requests overrides so that you can set timeouts. I'm less convinced about building the non-blocking queue like segment right now as the majority of our customers do this
themselves. happy to take a pass at this though for the defaults!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants