Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Licenses are missing copyright information #814

Open
arctic-alpaca opened this issue Feb 27, 2024 · 2 comments
Open

Licenses are missing copyright information #814

arctic-alpaca opened this issue Feb 27, 2024 · 2 comments
Labels
type: bug Something isn't working

Comments

@arctic-alpaca
Copy link
Contributor

Hi,

both the Apache 2 and the MIT license are missing the copyright information.
For the Apache 2 license, the copyright placeholder is not filled in: https://github.com/knurling-rs/defmt/blob/main/LICENSE-APACHE#L189
For the MIT license, the copyright part at the top (Copyright <YEAR> <COPYRIGHT HOLDER>, see here) is missing.

@jonathanpallant
Copy link
Contributor

The copyright line in that part of the Apache-2.0 licence is a template and is not supposed to be modified in the licence file itself. If you changed it, then you have a) modified the licence, and b) are telling anyone who reads your modified copy of the licence that they must put your copyright in their files when they wish to release it under your modified Apache-2.0 licence.

The copyright line is missing in the MIT file and we should fix that. I note it is also missing from the copy at GitHub.com/rust-lang so maybe we copied their file.

@arctic-alpaca
Copy link
Contributor Author

You are correct, the Apache-2.0 license file should not be modified, my bad. Without any form of copyright notice, I'm unsure how the copyright is assigned when using this project under the Apache-2.0 license.

The Rust repository has a COPYRIGHT file.

@Urhengulas Urhengulas added the type: bug Something isn't working label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants