Skip to content

Provide feedback when no new changes since last review #103

@malinosqui

Description

@malinosqui

Problem

When users run @kody start-review on a PR that was already analyzed with no new changes, Kody provides no feedback, leaving users unsure if the command worked.

Current Behavior

  • getChangedFilesSinceLastCommit() returns empty array when no changes
  • Pipeline is set to SKIP status in FetchChangedFilesStage
  • No user notification is provided

Expected Behavior

Add an informative comment explaining that the PR was already reviewed and no new changes were detected.

Technical Implementation

Files to modify:

  • src/core/infrastructure/adapters/services/codeBase/codeReviewPipeline/stages/fetch-changed-files.stage.ts
  • src/shared/utils/translations/dictionaries/en-US.json (and other languages)

Implementation Details:

  • In FetchChangedFilesStage.executeStage(), distinguish between "no files" due to filtering vs. "no new changes"
  • Check if lastExecution exists to determine if this is a re-review scenario
  • Use commentManagerService.createInitialComment() to post feedback comment
  • Include timestamp information when available

Message Template:

# Kody Review Complete ✅
**Info:** This PR has already been reviewed with no new changes detected.

If you've made new changes, ensure they're committed and pushed.

Acceptance Criteria

[ ] Re-reviews without changes receive explanatory comment
[ ] Comment includes relevant timestamp information
[ ] Distinguishes between "ignored files" and "no new changes" scenarios
[ ] All supported languages have translations
[ ] Works consistently across all supported platforms (GitHub, GitLab, Bitbucket, Azure Repos)

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions