-
Notifications
You must be signed in to change notification settings - Fork 288
Feature/handle mediatek nmea #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Note change 1 will be made obsolete by #90 . |
61b7853 to
98fecfe
Compare
|
@hraftery removed first change |
|
@kosma hi, can you please review my PR? |
|
I'm looking at the PR and I'm slightly confused, The Otherwise you're overwriting one byte past the structure and causing memory corruption. I'm surprised the tests pass. :o |
98fecfe to
7dd3c48
Compare
|
@kosma nice catch, pushed a fixed version. |
|
@kosma - can you please CR this change? |
|
On some of Mediatek chipsets, the SNR field is float instead of integer.
7dd3c48 to
14501f1
Compare
|
@kosma |
Hi, this PR allows the SNR field to be a float (happens in some of the mediatek chipsets).