Skip to content

Commit 18594fc

Browse files
Use requirements .in instead of .txt in setuptools
Refactoring `load_reqs` allow us more flexibility in the format of requirements we want to define and make usage of .in possible instead of the .txt. For example we can now define `protobuf>=5.28.2,<6`
1 parent e58a899 commit 18594fc

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

setup.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,11 @@
1414

1515
def load_reqs(filename):
1616
with open(filename) as reqs_file:
17-
return [
18-
re.sub('==', '>=', line) for line in reqs_file.readlines()
19-
if not re.match(r'(\s*#|-r)', line)
20-
]
17+
lines = [line.split("#")[0].strip() for line in reqs_file.readlines()]
18+
return [line for line in lines if line != ""]
2119

22-
23-
requirements = load_reqs('requirements/base.txt')
24-
test_requirements = load_reqs('requirements/test.txt')
20+
requirements = load_reqs('requirements/base.in')
21+
test_requirements = load_reqs('requirements/test.in')
2522

2623
setup(
2724
name='etcd3',

0 commit comments

Comments
 (0)