Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misconfigured backend prefix #30

Open
kimwnasptd opened this issue Feb 25, 2022 · 0 comments · Fixed by #32
Open

Misconfigured backend prefix #30

kimwnasptd opened this issue Feb 25, 2022 · 0 comments · Fixed by #32

Comments

@kimwnasptd
Copy link
Contributor

PR #27 updated the app's prefix in the VirtualService to kserve-endpoints, but it didn't configure the backend to use that value as well.

The manifests should also set the APP_PREFIX env var to be kserve-endpoints, or else index.html will use the incorrect tag <base href="/models/"> for all relative requests

https://github.com/kubeflow/kubeflow/blob/4ad0158e955e1144440e8bd16622c0e9d06df63f/components/crud-web-apps/common/backend/kubeflow/kubeflow/crud_backend/helpers.py#L20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

manifests: Update gateways and prefix kimwnasptd/models-web-app
1 participant
@kimwnasptd