Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Known error responses #17

Open
zevisert opened this issue Nov 15, 2023 · 0 comments
Open

Known error responses #17

zevisert opened this issue Nov 15, 2023 · 0 comments

Comments

@zevisert
Copy link

Curiously, the OpenAPI REST specification documents that the server may return HTTP status code 400 in some situations, but not in others that seemingly would have a higher propensity for error.

eg;

  • /v2/ (the parameterless server metadata endpoint) may respond with HTTP status code 400, while /v2/models/{MODEL_NAME}/versions/${MODEL_VERSION} (the parametrized model metadata endpoint) is documented to only respond with HTTP status code 200,
  • liveness and readiness only return status code 200 meaning their differences to kubernetes are non-existant.
    • Details on why liveness and readiness as documented are identicalIf the only documented HTTP response codes are 200 for liveness and readiness, then implementors can only assume that a spec-compliant server never responds with anything other than 200, meaning, if the server is reachable (a TCP connection can be established), then there is no difference between liveness or readiness since both APIs return the same code.

Relatedly, the gRPC spec does not mention possible error codes at all. Protobuf doesn't really have a mechanism in the language to document rcp error codes aside from comments, but a bit of documentation there about what clients can expect would be good as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant