Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Truncate Webui Service name #2300

Open
BCantos17 opened this issue Oct 29, 2024 · 3 comments · May be fixed by #2311
Open

[FEATURE] Truncate Webui Service name #2300

BCantos17 opened this issue Oct 29, 2024 · 3 comments · May be fixed by #2311
Assignees
@jacobsalway
Labels
kind/feature

Comments

@BCantos17
Copy link

What feature you would like to be added?

Truncate the service name of the web ui if the name reaches the character limit of 63

Why is this needed?

Kubernetes has a character limit for the names of their service and will fail to create if the limit is reached

Describe the solution you would like

Either truncate the name similar as seen in this file _helper.tpl file or what we see in spark kubernetes core

Describe alternatives you have considered

No response

Additional context

No response

Love this feature?

Give it a 👍 We prioritize the features with most 👍
@jacobsalway
Copy link
Member

jacobsalway commented Oct 29, 2024 •
edited
Loading

/assign @jacobsalway

I'll take on this feature request. I've run into the same issue internally pre 2.0 and copied the logic that Spark core uses https://github.com/apache/spark/blob/b6c569fe4d702e91c47ed7848b3c5cc173e59b19/resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala#L102-L116

@leticiasss
Copy link

Is there any update on this feature?

@jacobsalway jacobsalway linked a pull request Nov 5, 2024 that will close this issue
Open
8 tasks
@jacobsalway
Copy link
Member

@leticiasss I've raised a pull request that should fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobsalway jacobsalway

Labels
kind/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Truncate UI service name if over 63 characters jacobsalway/spark-operator
3 participants
@jacobsalway @BCantos17 @leticiasss