Common controller doesn't requeue on pvc finalizer remove err #957
Description
What happened:
The common snapshot controller will not requeue if intermittent errors prevent the removal of the PVC finalizer, such as
E1109 05:15:43.755196 1 snapshot_controller.go:191] error check and remove PVC finalizer for snapshot [datasource-test-63c30e708034]: snapshot controller failed to update datasource-test-63c30e708034 on API server: Operation cannot be fulfilled on persistentvolumeclaims "datasource-test-63c30e708034": the object has been modified; please apply your changes to the latest version and try again
The relevant code bit
external-snapshotter/pkg/common-controller/snapshot_controller.go
Lines 189 to 194 in facefba
What you expected to happen:
Finalizer removed
How to reproduce it:
Unit test is sufficient - inject an error to PVC Update() and observe that the controller doesn't return err/requeue
Anything else we need to know?:
Environment:
main branch of external-snapshotter