Fix recreating BucketAccess with Update method

kvaps · kvaps · commit d4fc96e5faec · 2024-07-31T18:32:25.000+02:00
diff --git a/pkg/bucketaccess/bucketaccess_controller.go b/pkg/bucketaccess/bucketaccess_controller.go
@@ -315,6 +315,12 @@ func (bal *BucketAccessListener) Update(ctx context.Context, old, new *v1alpha1.
 		if err != nil {
 			return bal.recordError(bucketAccess, v1.EventTypeWarning, events.FailedRevokeAccess, err)
 		}
+	} else {
+		// Trigger the Add logic to ensure that the BucketAccess is properly reconciled
+		err := bal.Add(ctx, bucketAccess)
+		if err != nil {
+			return bal.recordError(bucketAccess, v1.EventTypeWarning, events.FailedGrantAccess, err)
+		}
 	}
 
 	klog.V(3).InfoS("Update BucketAccess success",

Original file line number	Diff line number	Diff line change
`@@ -315,6 +315,12 @@ func (bal BucketAccessListener) Update(ctx context.Context, old, new v1alpha1.`
`315`	`315`	`if err != nil {`
`316`	`316`	`return bal.recordError(bucketAccess, v1.EventTypeWarning, events.FailedRevokeAccess, err)`
`317`	`317`	`}`
	`318`	`+ } else {`
	`319`	`+ // Trigger the Add logic to ensure that the BucketAccess is properly reconciled`
	`320`	`+ err := bal.Add(ctx, bucketAccess)`
	`321`	`+ if err != nil {`
	`322`	`+ return bal.recordError(bucketAccess, v1.EventTypeWarning, events.FailedGrantAccess, err)`
	`323`	`+ }`
`318`	`324`	`}`
`319`	`325`
`320`	`326`	`klog.V(3).InfoS("Update BucketAccess success",`