Replace deprecated linter and address warnings

Author: ash2k

.golangci.yml

@@ -14,7 +14,7 @@ linters:
     - dogsled
     - dupl
     - errcheck
-    - exportloopref
+    - copyloopvar
     - gochecknoinits
     - goconst
     - gocritic
@@ -46,6 +46,8 @@ linters-settings:
     line-length: 170
   gocyclo:
     min-complexity: 30
+  copyloopvar:
+    check-alias: true
 
 issues:
   # List of regexps of issue texts to exclude, empty list by default.
@@ -54,4 +56,4 @@ issues:
   # excluded by default patterns execute `golangci-lint run --help`
   exclude:
     - "Using the variable on range scope `tc` in function literal"
-    - "unused-parameter: parameter"
+    - "unused-parameter: parameter"

pkg/kstatus/polling/collector/collector_test.go

@@ -157,8 +157,7 @@ func TestCollectorEventProcessing(t *testing.T) {
 				if e.Resource != nil {
 					latestEventByIdentifier[e.Resource.Identifier] = e
 				}
-				ev := e
-				latestEvent = &ev
+				latestEvent = &e
 				eventCh <- e
 			}
 			// Give the collector some time to process the event.

pkg/kstatus/status/status_augment_test.go

@@ -132,7 +132,6 @@ func TestAugmentConditions(t *testing.T) {
 	}
 
 	for tn, tc := range testCases {
-		tc := tc
 		t.Run(tn, func(t *testing.T) {
 			u := y2u(t, tc.manifest)
 			addConditions(t, u, tc.withConditions)

pkg/kstatus/status/status_compute_test.go

@@ -249,7 +249,6 @@ func TestPodStatus(t *testing.T) {
 	}
 
 	for tn, tc := range testCases {
-		tc := tc
 		t.Run(tn, func(t *testing.T) {
 			runStatusTest(t, tc)
 		})
@@ -300,7 +299,6 @@ func TestPVCStatus(t *testing.T) {
 	}
 
 	for tn, tc := range testCases {
-		tc := tc
 		t.Run(tn, func(t *testing.T) {
 			runStatusTest(t, tc)
 		})
@@ -462,7 +460,6 @@ func TestStsStatus(t *testing.T) {
 	}
 
 	for tn, tc := range testCases {
-		tc := tc
 		t.Run(tn, func(t *testing.T) {
 			runStatusTest(t, tc)
 		})
@@ -624,7 +621,6 @@ func TestDaemonsetStatus(t *testing.T) {
 	}
 
 	for tn, tc := range testCases {
-		tc := tc
 		t.Run(tn, func(t *testing.T) {
 			runStatusTest(t, tc)
 		})
@@ -784,7 +780,6 @@ func TestDeploymentStatus(t *testing.T) {
 	}
 
 	for tn, tc := range testCases {
-		tc := tc
 		t.Run(tn, func(t *testing.T) {
 			runStatusTest(t, tc)
 		})
@@ -961,7 +956,6 @@ func TestReplicasetStatus(t *testing.T) {
 	}
 
 	for tn, tc := range testCases {
-		tc := tc
 		t.Run(tn, func(t *testing.T) {
 			runStatusTest(t, tc)
 		})
@@ -1016,7 +1010,6 @@ func TestPDBStatus(t *testing.T) {
 	}
 
 	for tn, tc := range testCases {
-		tc := tc
 		t.Run(tn, func(t *testing.T) {
 			runStatusTest(t, tc)
 		})
@@ -1144,7 +1137,6 @@ func TestCRDGenericStatus(t *testing.T) {
 	}
 
 	for tn, tc := range testCases {
-		tc := tc
 		t.Run(tn, func(t *testing.T) {
 			runStatusTest(t, tc)
 		})
@@ -1262,7 +1254,6 @@ func TestJobStatus(t *testing.T) {
 	}
 
 	for tn, tc := range testCases {
-		tc := tc
 		t.Run(tn, func(t *testing.T) {
 			runStatusTest(t, tc)
 		})
@@ -1311,7 +1302,6 @@ func TestCronJobStatus(t *testing.T) {
 	}
 
 	for tn, tc := range testCases {
-		tc := tc
 		t.Run(tn, func(t *testing.T) {
 			runStatusTest(t, tc)
 		})
@@ -1404,7 +1394,6 @@ func TestServiceStatus(t *testing.T) {
 	}
 
 	for tn, tc := range testCases {
-		tc := tc
 		t.Run(tn, func(t *testing.T) {
 			runStatusTest(t, tc)
 		})
@@ -1516,7 +1505,6 @@ func TestCRDStatus(t *testing.T) {
 	}
 
 	for tn, tc := range testCases {
-		tc := tc
 		t.Run(tn, func(t *testing.T) {
 			runStatusTest(t, tc)
 		})