Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip: fix(credential-provider): bump azcontainerregistry SKD to v0.2.3 to use ACR audience token #8593

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

wip: fix(credential-provider): bump azcontainerregistry SKD to v0.2.3 to use ACR audience token #8593

wants to merge 1 commit into from
+1 −1

Conversation

mainred
Copy link
Contributor

@mainred mainred commented Mar 11, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR bumps azcontainerregistry SKD to v0.2.3 to always use ACR audience token.

reference: Azure/azure-sdk-for-go#24215

Which issue(s) this PR fixes:

Fixes #8592

Special notes for your reviewer:

Does this PR introduce a user-facing change?

fix(credential-provider): bump azcontainerregistry SKD to v0.2.3 to use ACR audience token

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 11, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mainred
Once this PR has been reviewed and has the lgtm label, please assign nilo19 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from feiskyer and nilo19 March 11, 2025 23:38
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 11, 2025
@mainred
Copy link
Contributor Author

mainred commented Mar 11, 2025

We are expecting the azcontainerregistry SKD v0.2.3 to be cut to continue this PR

@mainred
Copy link
Contributor Author

mainred commented Mar 11, 2025

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2025
@k8s-ci-robot
Copy link
Contributor

@mainred: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cloud-provider-azure-unit 31ef921 link true /test pull-cloud-provider-azure-unit
pull-cloud-provider-azure-e2e-ccm-vmssflex-capz 31ef921 link true /test pull-cloud-provider-azure-e2e-ccm-vmssflex-capz
pull-cloud-provider-azure-e2e-ccm-vmss-ip-lb-capz 31ef921 link true /test pull-cloud-provider-azure-e2e-ccm-vmss-ip-lb-capz
pull-cloud-provider-azure-e2e-ccm-capz 31ef921 link true /test pull-cloud-provider-azure-e2e-ccm-capz
pull-cloud-provider-azure-e2e-ccm-vmss-multi-slb-capz 31ef921 link true /test pull-cloud-provider-azure-e2e-ccm-vmss-multi-slb-capz
pull-cloud-provider-azure-e2e-ccm-vmss-shared-probe-capz 31ef921 link true /test pull-cloud-provider-azure-e2e-ccm-vmss-shared-probe-capz
pull-cloud-provider-azure-e2e-ccm-vmss-capz 31ef921 link true /test pull-cloud-provider-azure-e2e-ccm-vmss-capz
pull-cloud-provider-azure-e2e-capz 31ef921 link true /test pull-cloud-provider-azure-e2e-capz

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer Awaiting requested review from feiskyer

@nilo19 nilo19 Awaiting requested review from nilo19

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

credential provider: pulling image fails when ARM audience token is disabled
2 participants
@mainred @k8s-ci-robot