Aggregate Deleting Condition Messages from Underlying Resources in CAPI v1beta2 #11893
Closed
LingyanCao
started this conversation in
General
Replies: 1 comment
-
Closing in favor of the issue: #11900 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
In CAPI v1beta2, the Deleting condition was introduced to track resource deletion progress. However, unlike the provisioning flow, the Deleting condition only checks whether a resource’s directly owned resources are deleted. It does not aggregate the Deleting condition reasons or error messages from underlying resources.
For example, when a Cluster resource is being deleted, it checks if the KubeadmControlPlane (KCP) CR is deleted. If not, it sets the Deleting condition with:
Reason: WaitingForControlPlaneDeletion
Message: Waiting for KubeadmControlPlane to be deleted
However, it does not read the Deleting condition from KubeadmControlPlane or propagate any underlying error messages that might explain why the deletion is blocked. This makes it difficult to diagnose failures, especially when dealing with infrastructure-related issues.
Would the community consider enhancing the Deleting condition aggregation to include underlying error messages from child resources, similar to how condition aggregation works in the provisioning flow?
Beta Was this translation helpful? Give feedback.
All reactions