Skip to content

Feature: Native SSA Support #3183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 of 9 tasks
sbueringer opened this issue Mar 30, 2025 · 6 comments
Open
1 of 9 tasks

Feature: Native SSA Support #3183

sbueringer opened this issue Mar 30, 2025 · 6 comments

Comments

@sbueringer
Copy link
Member

sbueringer commented Mar 30, 2025

Tasks:

Tasks controller-tools:

@sbueringer
Copy link
Member Author

cc @alvaroaleman @vincepri

@sbueringer
Copy link
Member Author

cc @JoelSpeed

@shashankram
Copy link

@sbueringer Could you describe what's the gap with SSA in controller-runtime? I was under the impression SSA is already supported with Client.Patch(ctx, obj, client.Apply)

@alvaroaleman
Copy link
Member

@sbueringer Could you describe what's the gap with SSA in controller-runtime? I was under the impression SSA is already supported with Client.Patch(ctx, obj, client.Apply)

Yep that works, but we want it to be a first-class citizen. Please see the initial issue for a list of missing things.

@shashankram
Copy link

@sbueringer Could you describe what's the gap with SSA in controller-runtime? I was under the impression SSA is already supported with Client.Patch(ctx, obj, client.Apply)

Yep that works, but we want it to be a first-class citizen. Please see the initial issue for a list of missing things.

I think I ran into a bug with SSA: #347 (comment)

Let me know if this is related to the issue being fixed.

@JoelSpeed
Copy link
Contributor

One gap that we have is the extraction functions for the ApplyConfigurations, which require openapi.json to be able to generate.

The first step of which is to use kube-openapi to generate the openapi definitions as generated Go code.

This code is then imported into models-schema which then generated an openapi.json file, much like you could retrieve from a Kube API server.

This openapi.json is then fed into the OpenAPISchemaFilePath argument to the applyconfiguration gen, which allows it to generate the extraction functions.

I'd be interested to see if there was a way that we could combine the first two stages so that we don't have to output the intermediate generated go code, and could put the openapi.json file in a known location or even a temp location for creating the extract functions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants