Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart does not propagate commonLabels to pods #4762

Open
ejstreet opened this issue Sep 19, 2024 · 0 comments
Open

Helm chart does not propagate commonLabels to pods #4762

ejstreet opened this issue Sep 19, 2024 · 0 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@ejstreet
Copy link

ejstreet commented Sep 19, 2024

What happened:
When setting commonLabels in the helm chart, the labels are not applied to pods, despite the description saying labels will be applied to "all chart resources".
What you expected to happen:
commonLabels should apply to pods, either by being included directly or using one of the helper wrappers in the pod template of the deployment.
How to reproduce it (as minimally and precisely as possible):
Set commonLabels. Pods do not get given labels.
Anything else we need to know?:
Minor issue, can be worked around by additionally setting podLabels.

Environment:

  • External-DNS version (use external-dns --version): n/a
  • DNS provider: n/a
  • Others: Helm Chart
@ejstreet ejstreet added the kind/bug Categorizes issue or PR as related to a bug. label Sep 19, 2024
@ejstreet ejstreet changed the title Helm chart does not propegate commonLabels to pods Helm chart does not propagate commonLabels to pods Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

1 participant