Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove serviceName CLI Flag #158

Closed
danehans opened this issue Jan 6, 2025 · 1 comment · Fixed by #271
Closed

Remove serviceName CLI Flag #158

danehans opened this issue Jan 6, 2025 · 1 comment · Fixed by #271

Comments

@danehans
Copy link
Contributor

danehans commented Jan 6, 2025 •
edited
Loading

The serviceName represents the name of the Service used by EPP for reading EndpointSlices. This means EPP needs to be restarted to read EndpointSlices from a different Service. Additionally, the serviceName is unneeded since the managed EndpointSlices can be discovered from inferencepool.spec.selector.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@danehans