Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce Namespace Scope of EndpointSliceReconciler #188

Closed
danehans opened this issue Jan 10, 2025 · 0 comments
Closed

Reduce Namespace Scope of EndpointSliceReconciler #188

danehans opened this issue Jan 10, 2025 · 0 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@danehans
Copy link
Contributor

Currently, the EndpointSlice reconciler is reconciling endpointslices across all namespaces. For example:

endpointslice_reconciler.go:102] Skipping EndpointSlice envoy-gateway-system/envoy-default-inference-gateway-6454a873-m4qlj because its service owner label envoy-default-inference-gateway-6454a873 doesn't match the pool service name vllm-llama2-7b-pool

Instead, the reconciler should be scoped to either a) the configured InferencePool namespace or b) the serviceName namespace if cross-namespace references are supported.
@danehans danehans changed the title Scope EndpointSliceReconciler to Configured InferencePool Namespace Reduce Namespace Scope of EndpointSliceReconciler Jan 10, 2025
@danehans danehans added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jan 29, 2025
@ahg-g ahg-g closed this as completed Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danehans @ahg-g