Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated way to generate helm templates #820

Open
kannon92 opened this issue Mar 6, 2025 · 2 comments · May be fixed by #824
Open

Automated way to generate helm templates #820

kannon92 opened this issue Mar 6, 2025 · 2 comments · May be fixed by #824

Comments

@kannon92
Copy link
Contributor

kannon92 commented Mar 6, 2025

We need to have some kind of sync or check to make sure that the helm templates do not differ from kustomize.

We can do this in phases but it is currently required that any CRD change must be copied to the helm crd directory because we don't autosync this.

This will easily be a bug in the future.
@andreyvelich
Copy link
Member

Thank you for creating this @kannon92!
@ChenYi015 has been working on the sync script as part of Kubeflow Trainer PR: kubeflow/trainer#2435
We can try to adopt it for JobSet also.

@ChenYi015
Copy link
Contributor

I am willing to contribute a shell script to sync manifests templated by Helm charts to Kustomize.

@ChenYi015 ChenYi015 linked a pull request Mar 7, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add bash script to sync manifests from Helm chart to Kustomize ChenYi015/jobset
3 participants
@kannon92 @andreyvelich @ChenYi015