Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: StartDateTime and EndDateTime, Timezones for NodePool Disruption Budgets #1446

Closed
ant-smith opened this issue Jul 18, 2024 · 7 comments · May be fixed by #2032
Closed

feat: StartDateTime and EndDateTime, Timezones for NodePool Disruption Budgets #1446

ant-smith opened this issue Jul 18, 2024 · 7 comments · May be fixed by #2032
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@ant-smith
Copy link

ant-smith commented Jul 18, 2024 •
edited
Loading

Description

What problem are you trying to solve?

As apart of planned events, there are instances in which budgets should be schedule-able within a human readable format that can be easily understood and reasoned about.

This feature should also follow the current standard of minimal ("most restrictive") budgeting when multiple budgets are defined with overlapping timeframes or crontab schedules.

How important is this feature to you?

This feature would enable operators to schedule budgets for many one-off events in the future when they are known about, without having to create and compare complex crontab definitions against one another.

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@ant-smith ant-smith added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 18, 2024
@ant-smith ant-smith mentioned this issue Jul 18, 2024
Closed
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Karpenter contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jul 18, 2024
@njtran
Copy link
Contributor

njtran commented Jul 25, 2024

Hey @ant-smith, can you copy some of our slack convo in here so others can chime in too?

@njtran
Copy link
Contributor

njtran commented Jul 25, 2024

Adding detail from the PR here as well:
This feature overall will assist operations teams in the following ways:

  • Overall more human readable, allowing an operator to easily reason if a budget is active or inactive at a glance
  • Support for many differing, but short lived time periods of disruption budgets over a longer timespan. E.g. there may be 15-18, 3-6 hour windows, over the course of 6 weeks that limit the clusters disruption in different ways. Writing cron's for this would be more difficult that start-end datetimes.
  • Support for empty start datetime, allows operators to say "From today until X, I want this to be active"
  • Support for empty end datetime, allows for operators to say "From today moving forward, I want this to be active"
  • Support for different timezones allow operators in separate timezones to manage separate sets of budgets, without converting to UTC first.
  • Dates are communicated in PST, needing to convert them adds friction and leaves a chance for errors as well as harder to quickly verify.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 23, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 22, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 22, 2024
@flavono123 flavono123 mentioned this issue Feb 26, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Milestone
No milestone
4 participants
@njtran @k8s-ci-robot @k8s-triage-robot @ant-smith