Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Electron 10 #6142

Closed
starpit opened this issue Nov 12, 2020 · 0 comments · Fixed by #6143
Closed

Update to Electron 10 #6142

starpit opened this issue Nov 12, 2020 · 0 comments · Fixed by #6143

Comments

@starpit
Copy link
Contributor

starpit commented Nov 12, 2020

This will require test updates, due to Spectron's switch to webdriverio v6. The webdriverio API changed substantially. For example this.app.client.getText(selector) must now be written as this.app.client.$(selector).then(_ => _.getText()).

Also, electron 10 will emit deprecation warnings, due to our need to disable allowRendererProcessReuse. electron/electron#18397

(electron) 'allowRendererProcessReuse' is deprecated and will be removed.

This is due to node-pty not yet supporting context aware modules: microsoft/node-pty#405

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant