Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using node-pty in Electron renderer process #7456

Closed
starpit opened this issue May 26, 2021 · 0 comments · Fixed by #7606
Closed

Stop using node-pty in Electron renderer process #7456

starpit opened this issue May 26, 2021 · 0 comments · Fixed by #7606
Labels
kind/flake Categorizes issue or PR as related to a flaky test. plugin/bash-like

Comments

@starpit
Copy link
Contributor

starpit commented May 26, 2021

This causes some issues:

  1. Electron has limited support for non-context-aware native modules. We have had to set app.allowRendererProcessReuse =true, which results in

(electron) 'allowRendererProcessReuse' is deprecated and will be removed.

  1. node-pty still does implement a context-aware module: non-context-aware native module microsoft/node-pty#405

  2. Electron post v10 will no longer allow the allowRendererProcessReuse hack, thus pinning us to Electron v10

I think we can address this by running the pty in the main process. The plugin-bash-like/pty/{client,server}.ts architecture already supports this separation. We need only write a channel that connects over electron ipc.

@starpit starpit added kind/flake Categorizes issue or PR as related to a flaky test. plugin/bash-like labels May 26, 2021
starpit added a commit to starpit/kui that referenced this issue May 26, 2021
starpit added a commit to starpit/kui that referenced this issue May 26, 2021
starpit added a commit to starpit/kui that referenced this issue May 26, 2021
starpit added a commit to starpit/kui that referenced this issue May 26, 2021
starpit added a commit to starpit/kui that referenced this issue May 26, 2021
starpit added a commit to starpit/kui that referenced this issue May 27, 2021
starpit added a commit to starpit/kui that referenced this issue May 28, 2021
starpit added a commit to starpit/kui that referenced this issue May 28, 2021
starpit added a commit to starpit/kui that referenced this issue Jun 8, 2021
starpit added a commit to starpit/kui that referenced this issue Jun 9, 2021
starpit added a commit to starpit/kui that referenced this issue Jun 9, 2021
starpit added a commit to starpit/kui that referenced this issue Jun 9, 2021
starpit added a commit to starpit/kui that referenced this issue Jun 10, 2021
starpit added a commit to starpit/kui that referenced this issue Jun 10, 2021
starpit added a commit to starpit/kui that referenced this issue Jun 11, 2021
starpit added a commit to starpit/kui that referenced this issue Jun 11, 2021
starpit added a commit to starpit/kui that referenced this issue Jun 11, 2021
starpit added a commit to starpit/kui that referenced this issue Jun 14, 2021
starpit added a commit to starpit/kui that referenced this issue Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/flake Categorizes issue or PR as related to a flaky test. plugin/bash-like
Projects
None yet
1 participant