-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using node-pty in Electron renderer process #7456
Labels
Comments
starpit
added a commit
to starpit/kui
that referenced
this issue
May 26, 2021
starpit
added a commit
to starpit/kui
that referenced
this issue
May 26, 2021
7 tasks
starpit
added a commit
to starpit/kui
that referenced
this issue
May 26, 2021
starpit
added a commit
to starpit/kui
that referenced
this issue
May 26, 2021
starpit
added a commit
to starpit/kui
that referenced
this issue
May 26, 2021
starpit
added a commit
to starpit/kui
that referenced
this issue
May 27, 2021
starpit
added a commit
to starpit/kui
that referenced
this issue
May 28, 2021
starpit
added a commit
to starpit/kui
that referenced
this issue
May 28, 2021
starpit
added a commit
to starpit/kui
that referenced
this issue
Jun 8, 2021
starpit
added a commit
to starpit/kui
that referenced
this issue
Jun 9, 2021
starpit
added a commit
to starpit/kui
that referenced
this issue
Jun 9, 2021
7 tasks
starpit
added a commit
to starpit/kui
that referenced
this issue
Jun 9, 2021
starpit
added a commit
to starpit/kui
that referenced
this issue
Jun 10, 2021
starpit
added a commit
to starpit/kui
that referenced
this issue
Jun 10, 2021
starpit
added a commit
to starpit/kui
that referenced
this issue
Jun 11, 2021
starpit
added a commit
to starpit/kui
that referenced
this issue
Jun 11, 2021
starpit
added a commit
to starpit/kui
that referenced
this issue
Jun 11, 2021
starpit
added a commit
to starpit/kui
that referenced
this issue
Jun 14, 2021
starpit
added a commit
to starpit/kui
that referenced
this issue
Jun 14, 2021
k8s-ci-robot
pushed a commit
that referenced
this issue
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
This causes some issues:
app.allowRendererProcessReuse =true
, which results innode-pty
still does implement a context-aware module: non-context-aware native module microsoft/node-pty#405Electron post v10 will no longer allow the
allowRendererProcessReuse
hack, thus pinning us to Electron v10I think we can address this by running the pty in the main process. The plugin-bash-like/pty/{client,server}.ts architecture already supports this separation. We need only write a channel that connects over electron ipc.
The text was updated successfully, but these errors were encountered: