Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate v1.Endpoints #4974

Open
2 of 4 tasks
danwinship opened this issue Nov 22, 2024 · 24 comments
Open
2 of 4 tasks

Deprecate v1.Endpoints #4974

danwinship opened this issue Nov 22, 2024 · 24 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/network Categorizes an issue or PR as relevant to SIG Network. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Milestone

Comments

@danwinship
Copy link
Contributor

danwinship commented Nov 22, 2024

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Nov 22, 2024
@danwinship
Copy link
Contributor Author

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 22, 2024
@danwinship danwinship self-assigned this Nov 22, 2024
@danwinship danwinship moved this to Pre-Alpha in SIG Network KEPs Jan 9, 2025
@thockin thockin self-assigned this Jan 9, 2025
@danwinship
Copy link
Contributor Author

/label lead-opted-in
/milestone v1.33

targeting alpha for 1.33

@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Jan 14, 2025
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Jan 14, 2025
@dipesh-rawat
Copy link
Member

dipesh-rawat commented Jan 28, 2025

Hello @danwinship 👋, v1.33 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

This enhancement is targeting stage alpha for v1.33 (correct me, if otherwise)
/stage alpha

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.32.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 6th February 2025 so that the PRR team has enough time to review your KEP.

For this KEP, we would need to update the following:

  • Create the KEP readme using the latest template and merge it in the k/enhancements repo.
  • Ensure that the KEP has undergone a production readiness review and has been merged into k/enhancements.

The status of this enhancement is marked as At risk for enhancements freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jan 28, 2025
@dipesh-rawat dipesh-rawat moved this to At risk for enhancements freeze in 1.33 Enhancements Tracking Jan 28, 2025
@sftim
Copy link

sftim commented Feb 7, 2025

Summary suggestion

-Further deprecate v1.Endpoints in favor of EndpointSlices, and ensure that it is possible to run clusters without the Endpoints controller.
+Deprecate Endpoints in favor of EndpointSlices, and ensure that it is possible to run clusters without the Endpoints controller.

@danwinship
Copy link
Contributor Author

danwinship commented Feb 8, 2025

  • We'd deprecate all versions of Endpoints I think.

v1 is the only version, so...

I was saying "v1.Endpoints" to make it clear I was talking about the API kind, not the generic concept of endpoints, the EndpointSlice field named Endpoints, etc.

@sftim
Copy link

sftim commented Feb 8, 2025

How about "the Endpoints API" then? That should be clear to all readers / would be more likely to be understood than v1.Endpoints.

@dipesh-rawat
Copy link
Member

Hi @danwinship 👋, 1.33 Enhancements team here,

Just a quick friendly reminder as we approach the enhancements freeze later this week, at 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

The current status of this enhancement is marked as At risk for enhancement freeze. There are a few requirements mentioned in the comment #4974 (comment) that still need to be completed.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@dipesh-rawat
Copy link
Member

Hello @danwinship 👋, 1.33 Enhancements team here.

Now that PR #4975 has been merged, all the KEP requirements are in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

/label tracked/yes

@k8s-ci-robot k8s-ci-robot added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Feb 11, 2025
@dipesh-rawat dipesh-rawat moved this from At risk for enhancements freeze to Tracked for enhancements freeze in 1.33 Enhancements Tracking Feb 11, 2025
@Urvashi0109
Copy link

Hello @danwinship 👋, v1.33 Docs Shadow here.

Does this enhancement work planned for v1.33 require any new docs or modification to existing docs?

If so, please follow the steps here to open a PR against dev-1.33 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 27th February 2025 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@dipesh-rawat
Copy link
Member

dipesh-rawat commented Feb 28, 2025

Hey again @danwinship 👋, 1.33 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Friday 21st March 2025 / 19:00 PDT Thursday 20th March 2025. .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

Additionally, please let me know if there are any other PRs in k/k not listed above that we should track for this KEP, so that we can maintain accurate status.

If you anticipate missing code freeze, you can file an exception request in advance.

The status of this enhancement is marked as at risk for code freeze.

@dipesh-rawat dipesh-rawat moved this from Tracked for enhancements freeze to At risk for code freeze in 1.33 Enhancements Tracking Feb 28, 2025
@rytswd
Copy link
Member

rytswd commented Mar 1, 2025

Hi @danwinship 👋 -- this is Ryota (@rytswd) from the 1.33 Communications Team!

For the 1.33 release, we are currently in the process of collecting and curating a list of potential feature blogs, and we'd love for you to consider writing one for your enhancement!

We are under impression that this would probably benefit from a blog post to clarify the actual impact and meaning of it -- as the change description may scare some users. We will be looking into writing a sneak peek blog and highlighting this KEP.

At the same time, it would be beneficial to have a dedicated blog to go deeper into the details with a separate blog post. To opt in to write a feature blog, could you please let us know and open a "Feature Blog placeholder PR" (which can be only a skeleton at first) against the website repository by Wednesday, 5th March, 2025? For more information about writing a blog, please find the blog contribution guidelines 📚

Tip

Some timeline to keep in mind:

  • 02:00 UTC Wednesday, 5th March, 2025: Feature blog PR freeze
  • Monday, 7th April, 2025: Feature blogs ready for review
  • You can find more in the release document

Note

In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

@danwinship
Copy link
Contributor Author

@sftim said in the PR review "Ideally, try to cover this in the 'mid point comms' blog about the upcoming release that will deprecate Endpoints." I'm not sure exactly what that means. 🙂

I have started writing a standalone blog post as well.

@rytswd
Copy link
Member

rytswd commented Mar 2, 2025

Thanks @danwinship, what Tim referred to was the sneak peek blog I mentioned, which is also known as mid cycle deprecation / removal blog. The Release Comms team will be working on putting one together.

If you have already started working on a dedicated blog, do you have a placeholder PR for that? If you haven't, would you be able to create one, and provide the PR number with us? It would help us track blogs associated with the release, and plan the appropriate schedule for publishing based on the impact and importance of the change (and this KEP will likely be on the top of the list).

We could also look to get the sneak peek blog to use the blog content if it would be short enough. We can discuss more a bit later as we get more into the actual write-up for the sneak peek blog 👍

@danwinship
Copy link
Contributor Author

done: kubernetes/website#49976

@rytswd
Copy link
Member

rytswd commented Mar 2, 2025

Thanks @danwinship! I have added the PR link under the Enhancement tracking board 👍

@sftim
Copy link

sftim commented Mar 3, 2025

@rytswd what you've called the "sneak peek" blog article was originally the place to announce upcoming deprecations and removals. I recommend announcing this deprecation in that article (and in the release announcement).

I don't see a benefit in a post-release article on top of doing those two things.

@rytswd
Copy link
Member

rytswd commented Mar 3, 2025

@sftim Noted, that makes sense! The Release Lead team has discussed this earlier and confirmed we would write the mid cycle blog to highlight this deprecation (along with other highlights).

We will make sure to capture this in the Release Blog as well, so I agree we can drop the dedicated Feature Blog.

@danwinship If you have some draft already, would you be able to share with me? If not, no worries, we will reach out to you for the review when our draft is ready 👍

@danwinship
Copy link
Contributor Author

the draft is in kubernetes/website#49976

@rytswd
Copy link
Member

rytswd commented Mar 3, 2025

Apologies, I thought it was an empty placeholder PR -- thanks for the share!

@sftim With the draft in kubernetes/website#49976, I'm thinking it may actually be helpful to keep this dedicated blog, and the Comms can highlight this deprecation in a more succinct manner with a link to this feature blog for more details. We could take the whole content here into the mid cycle blog, as well as the main Release Blog -- but it may be easier for users to have a dedicated blog, which they can easily search through the Kubernetes Blog rather than specifically checking 1.33 release blog. What do you think?

@sftim
Copy link

sftim commented Mar 4, 2025

We could take the whole content here into the mid cycle blog, as well as the main Release Blog

That feels viable. The main release announcement can hyperlink back to the section of the mid-cycle blog, and we can edit the mid-cycle blog post release to confirm the deprecation.

Alternative option: publish two articles on the same day:

  1. mid-cycle announcement
  2. a specific article about the deprecation of the Endpoints API, with the mid-cycle blog article linking to this one

The v1.33 release announcement can then reference (a slightly updated) article 2.

Why this? Well, the biggest publicity / social media grouching will be on the day we announce the deprecation and on release day. If we publish a post-release blog article, this arrives after peak grouching.

@rytswd
Copy link
Member

rytswd commented Mar 5, 2025

@sftim I'm personally leaning towards the second option of having a dedicated article for the deprecation of the Endpoints API. The mid cycle blog would surely be the first place to highlight this change, but I'm also aware many users would check the release blogs upon the actual release, or even weeks and months after the release. Having to go back to the mid cycle for the deprecation details after the release may be confusing to users.

I would love to help with the blog review for the dedicated one so that we can land it earlier, and it would be a more concise update in both the mid cycle and release announcement blogs.

@dipesh-rawat
Copy link
Member

Hi @danwinship 👋, 1.33 Enhancements team here,

Just a quick friendly reminder as we approach the code freeze later this week, at 02:00 UTC Friday 21st March 2025 / 19:00 PDT Thursday 20th March 2025.

The current status of this enhancement is marked as At risk for code freeze. There are a few requirements mentioned in the comment #4974 (comment) that still need to be completed.

If you anticipate missing code freeze, you can file an exception request in advance. Thank you!

@danwinship
Copy link
Contributor Author

@dipesh-rawat I have updated the checklist to label #129837 as no longer required for Alpha; although I still hope to get it in, we can call the feature Alpha even if it does not get in. (It just might require us to stay in Alpha an extra release before going to Beta if we don't get it in now.)

@dipesh-rawat
Copy link
Member

@danwinship Thanks, for the update and clarifying the changes needed for Alpha. I’ll mark this as tracked since all required PRs are merged. Also, please let me know if anything changes before the freeze or if there are any other PRs in k/k we should track for this KEP to keep the status accurate.

This enhancement is now marked as tracked for code freeze for the 1.33 Code Freeze!

@dipesh-rawat dipesh-rawat moved this from At risk for code freeze to Tracked for code freeze in 1.33 Enhancements Tracking Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/network Categorizes an issue or PR as relevant to SIG Network. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: Tracked for code freeze
Status: Pre-Alpha
Development

No branches or pull requests

7 participants