Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify registry address for .Values.controller.extraInitContainers #12324

Closed
larstobi opened this issue Nov 7, 2024 · 4 comments
Closed

Specify registry address for .Values.controller.extraInitContainers #12324

larstobi opened this issue Nov 7, 2024 · 4 comments
Labels
kind/support Categorizes issue or PR as a support question. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@larstobi
Copy link

larstobi commented Nov 7, 2024

I would like to be able to specify a private registry address when I add an extraInitContainers item to the .Values.controller.extraInitContainers value in values.yaml.

Example:

controller:
 extraInitContainers:
   - name: nginx-conf
     image: busybox:latest
     registry: myprivateregistry.org

Currently, if I add the registry property, it is ignored.

@larstobi larstobi added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 7, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 7, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@larstobi
Copy link
Author

larstobi commented Nov 7, 2024

I think maybe this is the place in the helm chart:

{{- if (or .Values.controller.extraInitContainers .Values.controller.extraModules) }}

@Gacko
Copy link
Member

Gacko commented Nov 7, 2024

extraInitContainers are directly getting passed into the template, so you need to define them as Kubernetes expects them. They are not changed in any way by the chart. For the same reason we sadly cannot apply the .global.image.registry logic there, which would enable you to set the registry for all images in a single place.

Have you tried prepending the registry to the image value?

@Gacko
Copy link
Member

Gacko commented Nov 7, 2024

/kind support

@k8s-ci-robot k8s-ci-robot added the kind/support Categorizes issue or PR as a support question. label Nov 7, 2024
@kubernetes kubernetes deleted a comment from k8s-ci-robot Nov 7, 2024
@Gacko Gacko removed the kind/feature Categorizes issue or PR as related to a new feature. label Nov 7, 2024
@Gacko Gacko closed this as completed Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/support Categorizes issue or PR as a support question. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Development

No branches or pull requests

3 participants