Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update kubeadm cgroup driver documentation once KubeletCgroupDriverFromCRI goes GA #3004

Open
neolit123 opened this issue Jan 30, 2024 · 7 comments
Labels
area/cri kind/documentation Categorizes issue or PR as related to documentation. priority/backlog Higher priority than priority/awaiting-more-evidence.
Milestone

Comments

@neolit123
Copy link
Member

neolit123 commented Jan 30, 2024

original k/k ticket:
kubernetes/kubernetes#99808

the new feature gate was added in a previous release and is planned for beta in 1.31:
kubernetes/enhancements#4033

once GA we should remove this page:
https://kubernetes.io/docs/tasks/administer-cluster/kubeadm/configure-cgroup-driver/

perhaps SIG node and feature owners will update:
https://kubernetes.io/docs/setup/production-environment/container-runtimes/#cgroup-drivers

users would still be required to pick a driver and configure it on the side of container runtimes (e.g. containerd).

@neolit123 neolit123 added priority/backlog Higher priority than priority/awaiting-more-evidence. kind/documentation Categorizes issue or PR as related to documentation. labels Jan 30, 2024
@neolit123 neolit123 added this to the Next milestone Jan 30, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 29, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 29, 2024
@neolit123 neolit123 removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 29, 2024
@neolit123 neolit123 modified the milestones: Next, v1.31 May 29, 2024
@pacoxu
Copy link
Member

pacoxu commented Jun 17, 2024

the new feature gate was added in a previous release and is planned for beta in 1.31:
kubernetes/enhancements#4033

This is planned to be beta in this release cycle.

  • We may use it if the FG is enabled and the cgroup driver can be detected from the CRI. And we can fall back to our previous logic if not.

@neolit123
Copy link
Member Author

neolit123 commented Jun 17, 2024

the new feature gate was added in a previous release and is planned for beta in 1.31:
kubernetes/enhancements#4033

This is planned to be beta in this release cycle.

  • We may use it if the FG is enabled and the cgroup driver can be detected from the CRI. And we can fall back to our previous logic if not.

i don't think we have any remaining logic for this, do we? we just set the cgroup driver to systemd.

https://github.com/kubernetes/kubernetes/blob/ef9965ebc66dafda37800bb04f5e284535bbba10/cmd/kubeadm/app/componentconfigs/kubelet.go#L194

@neolit123 neolit123 modified the milestones: v1.31, v1.32 Jul 3, 2024
@neolit123
Copy link
Member Author

KubeletCgroupDriverFromCRI went BETA in 1.31
kubernetes/kubernetes#125828

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 21, 2024
@pacoxu pacoxu removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 21, 2024
@pacoxu
Copy link
Member

pacoxu commented Oct 21, 2024

kubernetes/enhancements#4033 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cri kind/documentation Categorizes issue or PR as related to documentation. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

4 participants