Merge pull request #254 from kubernetes/fix-deprecated-actions

Fix CI by updating deprecated GitHub Actions and removing RBE

Author: k8s-ci-robot

.github/workflows/build-test.yml

@@ -25,14 +25,8 @@ jobs:
       fail-fast: false
       matrix:
         os:
-        - macos-latest
         - ubuntu-latest
         include:
-        - os: macos-latest
-          platform: "darwin-amd64"
-          cache-paths: |
-            /var/tmp/_bazel_runner/cache/repos/v1
-            ~/Library/Caches/bazelisk
         - os: ubuntu-latest
           platform: "linux-amd64"
           cache-paths: |
@@ -41,9 +35,9 @@ jobs:
 
     steps:
     - name: "checkout-repo"
-      uses: actions/checkout@v2
+      uses: actions/checkout@v4
     - name: "setup-cache"
-      uses: actions/cache@v2
+      uses: actions/cache@v4
       with:
         path: ${{ matrix.cache-paths }}
         key: ${{ runner.os }}-${{ hashFiles('.bazelversion') }}

.golangci.yml

@@ -1,11 +1,6 @@
 run:
-  deadline: 180s
+  timeout: 180s
   tests: true
-  skip-dirs:
-  - .git
-  - .tool
-  - vendor
-  - verify
 
 linters-settings:
   dupl:
@@ -16,13 +11,18 @@ linters-settings:
 linters:
   enable:
   - govet
-  - deadcode
-  - golint
+  - unused
+  - revive
   - gocyclo
   disable-all: true
 
 issues:
+  exclude-dirs:
+  - .git
+  - .tool
+  - vendor
+  - verify
   exclude-rules:
   - linters:
-    - golint
+    - revive
     text: ".*should not use dot dot imports"

cmd/kazel/generator.go

@@ -59,7 +59,7 @@ func (v *Vendorer) findGeneratorTags(root string, requestedTags map[string]bool)
 	tagsValuesPkgs = make(generatorTagsMap)
 	tagsPkgsValues = make(generatorTagsMap)
 
-	err = filepath.Walk(root, func(path string, info os.FileInfo, err error) error {
+	err = filepath.Walk(root, func(path string, _ os.FileInfo, err error) error {
 		if err != nil {
 			return err
 		}

defs/private/gcilint_repository.bzl

@@ -18,28 +18,33 @@ hundreds of dependencies, so using the binary release avoids dependency
 management toil.
 """
 
-_VERSION = "1.34.1"
+_VERSION = "1.64.8"
 
 _PLATFORMS = [
     struct(
         os = "darwin",
         arch = "amd64",
-        sha256 = "6c3d87f9f6bccd5954de9954c1e75d7b521abdcc956e0643929a75cbf4c00aad",
+        sha256 = "b52aebb8cb51e00bfd5976099083fbe2c43ef556cef9c87e58a8ae656e740444",
+    ),
+    struct(
+        os = "darwin",
+        arch = "arm64",
+        sha256 = "70543d21e5b02a94079be8aa11267a5b060865583e337fe768d39b5d3e2faf1f",
     ),
     struct(
         os = "linux",
         arch = "amd64",
-        sha256 = "23e4a9d8f89729007c6d749c245f725c2dbcfb194f4099003f9b826f1d386ad1",
+        sha256 = "b6270687afb143d019f387c791cd2a6f1cb383be9b3124d241ca11bd3ce2e54e",
     ),
     struct(
         os = "linux",
         arch = "arm64",
-        sha256 = "3bdfb7e619c665878d90cb73d45b35e8af6d753421cb8be07c40b63f3215bb02",
+        sha256 = "a6ab58ebcb1c48572622146cdaec2956f56871038a54ed1149f1386e287789a5",
     ),
     struct(
         os = "windows",
         arch = "amd64",
-        sha256 = "04473b63ee17374e7a55fd7ebe7fe97bc510ae9883e9214798dae8e67de4ba48",
+        sha256 = "54c2ed3a6b4f2f5da1056fb6e83d6b73b592e06684b65a5999174fabbb251a8f",
     ),
 ]
 
@@ -87,6 +92,7 @@ def gci_lint_alias():
         name = "golangci-lint",
         actual = select({
             "@io_bazel_rules_go//go/platform:darwin_amd64": "darwin_amd64/golangci-lint",
+            "@io_bazel_rules_go//go/platform:darwin_arm64": "darwin_arm64/golangci-lint",
             "@io_bazel_rules_go//go/platform:linux_arm64": "linux_arm64/golangci-lint",
             "@io_bazel_rules_go//go/platform:linux_amd64": "linux_amd64/golangci-lint",
             "@io_bazel_rules_go//go/platform:windows_amd64": "windows_amd64/golangci-lint",

hack/verify-golangci-lint.sh

@@ -43,7 +43,11 @@ export GOPROXY=https://proxy.golang.org
 export GOSUMDB=sum.golang.org
 export HOME=$TEST_TMPDIR/home
 export GOPATH=$HOME/go
-PATH=$(dirname "$1"):$PATH
+go_bin_dir=$(cd "$(dirname "$1")" && pwd)
+export GOROOT=$(cd "${go_bin_dir}/.." && pwd)
+PATH=${go_bin_dir}:$PATH
 export PATH
 shift 2
+export CGO_ENABLED=0
+go mod download
 "$golangci_lint" run "$@"

presubmit.sh

@@ -19,12 +19,10 @@ set -o pipefail
 
 cd "$(git rev-parse --show-toplevel)"
 
-if [[ -n "${GOOGLE_APPLICATION_CREDENTIALS:-}" ]]; then
-  echo "Service account detected. Adding --config=ci to bazel commands" >&2
-  mkdir -p "$HOME"
-  touch "$HOME/.bazelrc"
-  echo "build --config=ci" >> "$HOME/.bazelrc"
-fi
+# NOTE: Remote Build Execution (RBE) is no longer available.
+# The --config=ci flag previously enabled RBE but the backend
+# (projects/k8s-prow-builds/instances/default_instance) has been
+# decommissioned. Bazel now runs locally.
 (
   set -o xtrace
   bazel test //... # This also builds everything

tools/build_tar/buildtar.go

@@ -368,7 +368,7 @@ func (f *tarFile) addTar(toAdd string) error {
 	return nil
 }
 
-func (f *tarFile) addDeb(toAdd string) error {
+func (f *tarFile) addDeb(_ string) error {
 	return fmt.Errorf("addDeb unimplemented")
 }