Remove unused function from test helper

Signed-off-by: Krzysztof Wilczyński <[email protected]>

Author: kwilczynski

go.mod

@@ -1,5 +1,3 @@
 module github.com/kwilczynski/go-magic
 
 go 1.15
-
-require github.com/stretchr/testify v1.6.1

helper_test.go

@@ -3,9 +3,6 @@ package magic
 import (
 	"bytes"
 	"path"
-	"reflect"
-	"runtime"
-	"testing"
 )
 
 var (
@@ -25,41 +22,9 @@ var (
 	shellMagicFile = path.Clean(path.Join(fixturesDirectory, "shell.magic"))
 )
 
-func skip(t *testing.T, message string) {
-	// XXX(krzysztof): Attempt to circumvent lack of T.Skip() prior to Go version go1.1 ...
-	f := reflect.ValueOf(t).MethodByName("Skip")
-	if ok := f.IsValid(); !ok {
-		f = reflect.ValueOf(t).MethodByName("Log")
-	}
-
-	f.Call([]reflect.Value{reflect.ValueOf(message)})
-}
-
 func compareStrings(this, other string) bool {
 	if this == "" || other == "" {
 		return false
 	}
 	return bytes.Equal([]byte(this), []byte(other))
 }
-
-func oldGoVersion() (bool, string) {
-	// Contains every release of Go prior to
-	// when the `os.Unsetenv()` function was
-	// added in the version 1.4.x and newer.
-	versions := []string{
-		"go1", "go1.0.1",
-		"go1.0.2", "go1.0.3",
-		"go1.1", "go1.1.1", "go1.1.2",
-		"go1.2", "go1.2.1", "go1.2.2",
-		"go1.3", "go1.3.1", "go1.3.2", "go1.3.3",
-	}
-
-	version := runtime.Version()
-
-	for _, v := range versions {
-		if v == version {
-			return true, version
-		}
-	}
-	return false, version
-}

magic_test.go

@@ -161,7 +161,7 @@ func TestMagic_String(t *testing.T) {
 	}
 }
 
-func TestMagic_Path(t *testing.T) {
+func TestMagic_Paths(t *testing.T) {
 	var mgc *Magic
 	var rv []string
 
@@ -184,9 +184,9 @@ func TestMagic_Path(t *testing.T) {
 
 	mgc.Close()
 
-	// XXX(krzysztof): Setting "MAGIC" here breaks tests later as it will
-	// be persistent between different tests, sadly needed to be disabled
-	// for the time being.
+	// Setting "MAGIC" here breaks tests later as it will be persistent
+	// between different tests, sadly needed to be disabled for the time
+	// being.
 	//
 	//	p, err := os.Getwd()
 	//	if err != nil {
@@ -203,9 +203,9 @@ func TestMagic_Path(t *testing.T) {
 	//		t.Errorf("value given %q, want %q", v[0], p)
 	//	}
 
-	// TODO(kwilczynski): Test Magic.Load() affecting Magic.Path() as well. But
-	// that requires working os.Clearenv() which is yet to be implemented as
-	// per http://golang.org/src/pkg/syscall/env_unix.go?s=1772:1787#L101
+	// Test Magic.Load() affecting Magic.Path() as well. But that requires
+	// working os.Clearenv() which is yet to be implemented as per
+	// http://golang.org/src/pkg/syscall/env_unix.go?s=1772:1787#L101
 
 	mgc, _ = open()
 	defer func() {
@@ -218,11 +218,7 @@ func TestMagic_Path(t *testing.T) {
 	}
 }
 
-func TestMagic_Path_Environment(t *testing.T) {
-	if ok, v := oldGoVersion(); ok {
-		skip(t, fmt.Sprintf("this version of the Go Language is too old: %s", v))
-		return // Should not me reachable on modern Go version.
-	}
+func TestMagic_Paths_Environment(t *testing.T) {
 }
 
 func TestMagic_Parameter(t *testing.T) {
@@ -448,10 +444,6 @@ func TestMagic_Load(t *testing.T) {
 }
 
 func TestMagic_Load_Environment(t *testing.T) {
-	if ok, v := oldGoVersion(); ok {
-		skip(t, fmt.Sprintf("this version of the Go Language is too old: %s", v))
-		return // Should not me reachable on modern Go version.
-	}
 }
 
 func TestMagic_Compile(t *testing.T) {