Skip to content

Commit 08cec05

Browse files
authored
Remove default for isitioInjection and update its usage (#1934)
1 parent a2f6312 commit 08cec05

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

config/buildless-serverless/files/kyma-commands.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,6 @@ subCommands:
179179
- type: bool
180180
name: istio-injection
181181
description: "Enable Istio sidecar injection"
182-
default: ""
183182
with:
184183
output: ${{ .flags.output.value }}
185184
dryRun: ${{ .flags.dryrun.value }}
@@ -190,7 +189,7 @@ subCommands:
190189
name: ${{ .args.value }}
191190
namespace: ${{ .flags.namespace.value }}
192191
annotations:
193-
${{ .flags.istioinjection.value | wasUsed "{'sidecar.istio.io/inject':'true'}" "{'sidecar.istio.io/inject':'false'}" "" }}
192+
${{ .flags.istioinjection.value | ifNil "{'sidecar.istio.io/inject':'${{.flags.istioinjection.value}}'}" "" }}
194193
spec:
195194
runtimeImageOverride: ${{ .flags.runtimeimageoverride.value }}
196195
runtime: nodejs22

config/serverless/files/kyma-commands.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,6 @@ subCommands:
148148
- type: bool
149149
name: istio-injection
150150
description: "Enable Istio sidecar injection"
151-
default: ""
152151
with:
153152
output: ${{ .flags.output.value }}
154153
dryRun: ${{ .flags.dryrun.value }}
@@ -159,7 +158,7 @@ subCommands:
159158
name: ${{ .args.value }}
160159
namespace: ${{ .flags.namespace.value }}
161160
annotations:
162-
${{ .flags.istioinjection.value | wasUsed "{'sidecar.istio.io/inject':'true'}" "{'sidecar.istio.io/inject':'false'}" "" }}
161+
${{ .flags.istioinjection.value | ifNil "{'sidecar.istio.io/inject':'${{.flags.istioinjection.value}}'}" "" }}
163162
spec:
164163
runtimeImageOverride: ${{ .flags.runtimeimageoverride.value }}
165164
runtime: nodejs22

0 commit comments

Comments
 (0)