Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

Better CJK support in Webterm #9

Open
achimnol opened this issue Feb 9, 2017 · 0 comments
Open

Better CJK support in Webterm #9

achimnol opened this issue Feb 9, 2017 · 0 comments
Labels
enhancement

Comments

@achimnol
Copy link
Member

achimnol commented Feb 9, 2017

At least let's print them correctly.
achimnol added a commit that referenced this issue Feb 9, 2017
@achimnol
refs #9: Replace terminal.js with xterm.
2f4ae3f 
 * xterm-js is better maintained and has explicit support to CJK.

 * Currently printing works okay (Korean chars occupy exactly the space
   of two alphabet chars) but typing does not work. :(

 * TODO: embed CSS as one of Sorna's static asset.
achimnol added a commit that referenced this issue Feb 11, 2017
@achimnol
refs #7, #9: Improve webterm.
c69d5ec 
 * Include xterm.css into a part of webpack bundle.
   No additional <link> tags are required; it's automatically imported
   when doing `Sorna.loadWebterm();`

 * Modified xterm.css to make it more vibrant and readable.

 * Update README and webpack configs so that you can use `yarn run ...`
   to run pre-configured build/devserver commands using the local
   node_modules directory.

 * Resetting kernel no longer duplicates keypress events.

 * Now the terminal handles CJK and English input/output correctly.
   (tested only on Chrome)
achimnol added a commit that referenced this issue Feb 13, 2017
@achimnol
refs #7, #9, #10: Clean up JS dependencies
4e80bce 
 * To cope with non-webpack-compatible build processes, imported
   xterm.js and fabric.js into our own "vendor" directory.

   - fabric.js is downloaded from the official customized builder
     (http://fabricjs.com/build/) and slightly modified to remove
     extra "reuqire()" calls that confuse webpack.

   - xterm.js is built from our fork (https://github.com/lablup/xterm.js)
     and the color scheme in xterm.css is modified to match our flavor.

   - In our fork of xterm.js, we have patched non-IME character inputs
     for macOS/iOS Safari.
achimnol added a commit that referenced this issue Feb 13, 2017
@achimnol
refs #9: Update xterm.js vendor lib.
9e4ef64
achimnol added a commit that referenced this issue Feb 13, 2017
@achimnol
refs #9: Fix reference to removed variables.
251bf39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@achimnol