fix(FR-366): remove unnecessary panel disabling via querySelector at vfolder invitation panel in summary view page #3029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
lizable
requested review from
agatha197,
leksikov,
nowgnuesLee and
yomybaby
and removed request for
leksikov
yomybaby
changed the title
yomybaby
requested changes
Jan 15, 2025
agatha197
approved these changes
Jan 15, 2025
|
I applied it. It would be look like this. After clicking |
Merge activity
|
…vfolder invitation panel in summary view page (#3029) resolves #3023 (FR-366) Removes unnecessary UI element disabling when accepting or declining vfolder invitations. Previously, the code would disable the entire panel and all buttons when processing these actions, which was redundant since the operations are quick and the panel gets removed upon completion anyway. Also fixes a typo in the method documentation ("vfloder" -> "vfolder"). ### How to test > Prerequisites: You need two user account to test this. 1. Login with user A. 2. Create at least two vfolders if there's no vfolder created. 3. Invite user B with vfolders created in step 2 or that alreay exists. 4. Logout user A and Login with user B. 5. Go to `Summary` page. 6. See the Invitation panel. 7. Click Accept/Decline inside the panel. 8. Click another one in the panel. **Checklist:** - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
yomybaby
force-pushed
the
hotfix/invitation-panel-disabled-when-clicked-accept-or-decline
branch
from
d9f89a1 to
c04f7c9
Compare
graphite-app
bot
deleted the
hotfix/invitation-panel-disabled-when-clicked-accept-or-decline
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3023 (FR-366)
Removes unnecessary UI element disabling when accepting or declining vfolder invitations. Previously, the code would disable the entire panel and all buttons when processing these actions, which was redundant since the operations are quick and the panel gets removed upon completion anyway.
Also fixes a typo in the method documentation ("vfloder" -> "vfolder").
How to test
Summarypage.Checklist: