Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(FR-656) Modify the icon-related design on the session page #3338

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore(FR-656) Modify the icon-related design on the session page #3338

wants to merge 2 commits into from
+16 −7

Conversation

nowgnuesLee
Copy link
Contributor

@nowgnuesLee nowgnuesLee commented Mar 12, 2025 •
edited
Loading

resolves #3337 (FR-656)
This PR modify the icon-related design on the session page.

changes

  • modify the spacing between the copyable icon and the log icon.
    before
    image.png
    after
    스크린샷 2025-03-12 오전 11.20.28.png

  • display '-' if container ID is not available.
    before
    image.png
    after
    스크린샷 2025-03-12 오전 11.21.58.png

Checklist: (if applicable)

  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Sorry, something went wrong.

@github-actions github-actions bot added the size:S 10~30 LoC label Mar 12, 2025
@nowgnuesLee Graphite App
Copy link
Contributor Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions GitHub Actions
Copy link

Coverage report for ./react

Action wasn't able to generate report within GitHub comment limit. If you're facing this issue, please let me know by commenting under this issue.

Report generated by 🧪jest coverage report action from 40a055f

@nowgnuesLee nowgnuesLee changed the title chore: Modify the icon-related design on the session page chore(FR: Modify the icon-related design on the session page Mar 12, 2025
@nowgnuesLee nowgnuesLee changed the title chore(FR: Modify the icon-related design on the session page chore(FR:656) Modify the icon-related design on the session page Mar 12, 2025
@nowgnuesLee nowgnuesLee marked this pull request as ready for review March 12, 2025 02:22
@nowgnuesLee nowgnuesLee changed the title chore(FR:656) Modify the icon-related design on the session page chore(FR-656) Modify the icon-related design on the session page Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agatha197 agatha197

@ironAiken2 ironAiken2

@yomybaby yomybaby

At least 1 approving review is required to merge this pull request.

Assignees

@nowgnuesLee nowgnuesLee

Labels
size:S 10~30 LoC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modify the icon-related design on the session page
1 participant
@nowgnuesLee