Optional wait parameters on captures #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianstirling
requested changes
May 2, 2025
Contributor
julianstirling
left a comment
julianstirling
left a comment
There was a problem hiding this comment.
Type hints don't agree with default value, for wait.
Should we put in a default of 5s? Or even 0.9s so it works even on Pis that don't have the updated yaml?
Collaborator
Author
|
Default value is now 0.9, optionally so None can be passed |
Contributor
|
Hi Joe, This looks great. Have you tested this on a Pi? If so I think it is ready. |
Collaborator
Author
Tested it on my microscope, all works as expected |
julianstirling
approved these changes
May 2, 2025
Contributor
julianstirling
left a comment
julianstirling
left a comment
There was a problem hiding this comment.
Thanks for the changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused import, and add wait parameters to captures. Default to None, so behaviour won't be changed