environment.cpp: use QString::toInt() instead of atoi()

johanmalm · johanmalm · commit 7785af8b190e · 2025-11-30T20:51:29.000Z
diff --git a/src/environment.cpp b/src/environment.cpp
@@ -50,8 +50,9 @@ int environmentGetInt(QString key)
             continue;
         }
         if (line->key == key) {
-            // TODO: Not ideal
-            return atoi(line->value.toStdString().c_str());
+            bool success = false;
+            int ret = line->value.toInt(&success);
+            return success ? ret : -1;
         }
     }
     return -1;

Original file line number	Diff line number	Diff line change
`@@ -50,8 +50,9 @@ int environmentGetInt(QString key)`
`50`	`50`	`continue;`
`51`	`51`	`}`
`52`	`52`	`if (line->key == key) {`
`53`		`- // TODO: Not ideal`
`54`		`- return atoi(line->value.toStdString().c_str());`
	`53`	`+ bool success = false;`
	`54`	`+ int ret = line->value.toInt(&success);`
	`55`	`+ return success ? ret : -1;`
`55`	`56`	`}`
`56`	`57`	`}`
`57`	`58`	`return -1;`