Addressing failing test

Author: ladeak

src/CHttpServer/CHttpServer/Http2Stream.cs

@@ -60,8 +60,8 @@ public Http2Stream(uint streamId, uint initialWindowSize, Http2Connection connec
         RequestEndHeaders = false;
         _requestHeaders = new HeaderCollection();
         _requestContentPipe = new(new PipeOptions(MemoryPool<byte>.Shared));
-        _requestContentPipeReader = new(_requestContentPipe.Reader, ReleaseFlowControl);
-        _requestContentPipeWriter = new(_requestContentPipe.Writer, ConsumeFlowControl);
+        _requestContentPipeReader = new(_requestContentPipe.Reader, ReleaseServerFlowControl);
+        _requestContentPipeWriter = new(_requestContentPipe.Writer, ConsumeServerFlowControl);
 
         _responseContentPipe = new(new PipeOptions(MemoryPool<byte>.Shared));
         _responseContentPipeWriter = new(_responseContentPipe.Writer, size =>
@@ -160,30 +160,29 @@ public void Abort()
 
     public void CompleteRequestStream()
     {
-        _requestContentPipe.Writer.Complete();
+        _requestContentPipeWriter.Complete();
         _state = StreamState.HalfOpenRemote;
     }
 
-    private void ReleaseFlowControl(int size)
+    private void ReleaseServerFlowControl(int size)
     {
         if (size > Http2Connection.MaxWindowUpdateSize || size < 0)
             throw new Http2FlowControlException();
+        if(size == 0)
+            return;
         uint windowSize = (uint)size;
         _serverWindowSize.ReleaseSize(windowSize);
 
         // Release Read FlowControl Window for the stream and the connection.
         _writer.ScheduleWriteWindowUpdate(this, windowSize);
     }
 
-    private void ConsumeFlowControl(uint size)
+    private void ConsumeServerFlowControl(int size)
     {
         if (size > Http2Connection.MaxWindowUpdateSize || size < 0)
             throw new Http2FlowControlException();
         uint windowSize = (uint)size;
         _serverWindowSize.TryUse(windowSize);
-
-        // Release Read FlowControl Window for the stream and the connection.
-        _writer.ScheduleWriteWindowUpdate(this, windowSize);
     }
 }
 
@@ -298,7 +297,11 @@ public async Task CompleteAsync()
     {
         var task = _responseWritingTask;
         if (task == null)
+        {
             await StartAsync();
+        }
+        // Make sure the thread can complete if it is waiting on write.
+        _applicationStartedResponse.Release(1);
         await _responseWritingTask!;
     }
 

tests/CHttpServer.Tests/ChttpServerIntegrationTests.cs

@@ -205,7 +205,7 @@ public async Task LargerInput_Than_FlowControl()
     {
         var client = CreateClient();
         var request = new HttpRequestMessage(HttpMethod.Get, "https://localhost:7222/readallinput") { Version = HttpVersion.Version20 };
-        request.Content = new ByteArrayContent(new byte[10_000_000]);
+        request.Content = new ByteArrayContent(new byte[5000]); //10_000_000
         var response = await client.SendAsync(request, TestContext.Current.CancellationToken);
         Assert.True(response.IsSuccessStatusCode);
     }