Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish real paths from virtual paths in Filesystem #1215

Open
DanRStevens opened this issue Feb 12, 2025 · 0 comments
Open

Distinguish real paths from virtual paths in Filesystem #1215

DanRStevens opened this issue Feb 12, 2025 · 0 comments

Comments

@DanRStevens
Copy link
Collaborator

The Filesystem API has mixed meaning for path parameters, where some paths are real filesystem paths such as the mount calls, while others represent Filesystem provided virtual paths. Perhaps we should use separate types to distinguish these.

It would be possible to wrap the current path data types in new struct data types to distinguish them. Or possibly we want to make the internal path datatype an implementation detail.


Including the <filesystem> header from Filesystem.h adds significantly to the build time when including Filesystem.h. Perhaps we can use custom struct types for the two types of path parameters, and not expose the internal workings of how they are handled. That could allow us to remove the <filesystem> include from Filesystem.h, and instead only include <filesystem> from the implementation file.


Related:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant