You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Filesystem API has mixed meaning for path parameters, where some paths are real filesystem paths such as the mount calls, while others represent Filesystem provided virtual paths. Perhaps we should use separate types to distinguish these.
It would be possible to wrap the current path data types in new struct data types to distinguish them. Or possibly we want to make the internal path datatype an implementation detail.
Including the <filesystem> header from Filesystem.h adds significantly to the build time when including Filesystem.h. Perhaps we can use custom struct types for the two types of path parameters, and not expose the internal workings of how they are handled. That could allow us to remove the <filesystem> include from Filesystem.h, and instead only include <filesystem> from the implementation file.
The
Filesystem
API has mixed meaning forpath
parameters, where some paths are real filesystem paths such as themount
calls, while others representFilesystem
provided virtual paths. Perhaps we should use separate types to distinguish these.It would be possible to wrap the current
path
data types in newstruct
data types to distinguish them. Or possibly we want to make the internalpath
datatype an implementation detail.Including the
<filesystem>
header fromFilesystem.h
adds significantly to the build time when includingFilesystem.h
. Perhaps we can use customstruct
types for the two types ofpath
parameters, and not expose the internal workings of how they are handled. That could allow us to remove the<filesystem>
include fromFilesystem.h
, and instead only include<filesystem>
from the implementation file.Related:
std::filesystem::path
instead ofstd::string
for filepath arguments #973std::filesystem::path
inFilesystem
#1078The text was updated successfully, but these errors were encountered: