Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of OpenGL resources #1228

Open
DanRStevens opened this issue Feb 17, 2025 · 0 comments
Open

Fix handling of OpenGL resources #1228

DanRStevens opened this issue Feb 17, 2025 · 0 comments

Comments

@DanRStevens
Copy link
Collaborator

DanRStevens commented Feb 17, 2025

It was recently noted that we might not be handling OpenGL resources correctly, such as by freeing them after we are done using them.

In Image.cpp in generateFbo there is a call to glGenTextures where the variable holding the ID simply goes out of scope. It does pass the value to glBindTexture first, but I doubt it get's read back and handled anywhere else.

The only potential use of the code in question is from RendererOpenGL::drawImageToImage, which is currently unused by NAS2D and OPHD.


Relevant documentation:

Other related documentation:

Related:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant