Merge pull request #48 from Paliak/gui-tweaks

Implement a few gui tweaks to the details panel so that it looks better on small width terminals

Author: laixintao

src/pingtop/models.py

@@ -7,7 +7,7 @@
 from typing import Protocol
 
 HostId = str
-MAX_HISTORY = 60
+MAX_HISTORY = 64
 TREND_BLOCKS = "▁▂▃▄▅▆▇█"
 TIMEOUT_MARKER = "╳"
 

src/pingtop/widgets/details_panel.py

@@ -4,6 +4,7 @@
 
 from rich.text import Text
 from textual.widgets import Static
+import pingtop.models
 
 from pingtop.widgets.trend import render_detailed_trend_graph
 
@@ -33,11 +34,11 @@ def _fmt(value: object) -> str:
     def _graph_width(self, left_width: int) -> int:
         if self.size.width <= 0:
             return 32
-        available = self.size.width - left_width - self.COLUMN_GAP - 6
-        return max(16, min(72, available))
+        available = self.size.width - left_width - self.COLUMN_GAP - 8
+        return max(16, min(pingtop.models.MAX_HISTORY, available))
 
     def _left_column_lines(self, row: dict[str, object]) -> list[str]:
-        return [
+        lines = [
             f"Host: {row['target']}",
             f"IP: {row['resolved_ip'] or '-'}",
             f"State: {row['state']}",
@@ -48,9 +49,14 @@ def _left_column_lines(self, row: dict[str, object]) -> list[str]:
             f"StdDev: {self._fmt(row['stddev_ms'])}",
             f"Sent: {row['seq']}",
             f"Loss: {row['lost']} ({float(cast(float, row['loss_percent'])):.1f}%)",
-            f"Error: {self._truncate(str(row['last_error'] or '-'))}",
         ]
 
+        last_err = row.get('last_error')
+        if last_err not in (None, '', b''):
+            lines.append(f"Error: {self._truncate(str(last_err))}")
+
+        return lines
+
     def _left_column_width(self, lines: list[str]) -> int:
         if not lines:
             return 0

src/pingtop/widgets/trend.py

@@ -105,11 +105,8 @@ def render_detailed_trend_graph(
 
     low = min(samples)
     high = max(samples)
-    avg = sum(samples) / len(samples)
     span = max(high - low, 1.0)
     label_width = max(len(f"{low:.1f}"), len(f"{high:.1f}"))
-    header.append(f"  {low:.1f}..{high:.1f} ms", style=DETAIL_GRAPH_AXIS_STYLE)
-    header.append(f"  avg {avg:.1f}", style=DETAIL_GRAPH_AXIS_STYLE)
 
     lines = [header]
     for level in range(height, 0, -1):
@@ -128,10 +125,11 @@ def render_detailed_trend_graph(
                 line.append("█", style=TREND_STYLES[bucket])
             else:
                 line.append("·", style=DETAIL_GRAPH_EMPTY_STYLE)
+        for _ in range(width - len(cells)):
+             line.append("·", style=DETAIL_GRAPH_EMPTY_STYLE)
         lines.append(line)
 
-    lines.append(_render_graph_axis(len(cells), label_width))
-    lines.append(Text(" " * (label_width + 3) + "oldest -> newest", style=DETAIL_GRAPH_AXIS_STYLE))
+    lines.append(_render_graph_axis(width, label_width))
     return lines