Skip to content

Conversation

@mackrorysd
Copy link

For this issue: #5314.

No test included because this is removing behavior that currently doesn't work and is only partially documented (unless we decide we want to fully implement an FTS alias for INVERTED indices. INVERTED index tests should continue to work.

@github-actions
Copy link
Contributor

ACTION NEEDED
Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

Copy link
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're sure it wasn't working before then this change seems fine to me (and the fact that no tests failed or needed changed is a sign this wasn't tested at all).

Can you fix up the PR title before you merge so it conforms to https://www.conventionalcommits.org/en/v1.0.0/?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants