Skip to content

Added 2 items in carousel#446

Closed
Aman1919 wants to merge 2 commits intolayer5io:masterfrom
Aman1919:carousel-fix
Closed

Added 2 items in carousel#446
Aman1919 wants to merge 2 commits intolayer5io:masterfrom
Aman1919:carousel-fix

Conversation

@Aman1919
Copy link

@Aman1919 Aman1919 commented Feb 15, 2025 •
edited
Loading

Notes for Reviewers

This PR fixes #437

Screencast.from.2025-02-15.16-16-07.webm

Signed commits

  • Yes, I signed my commits.

@Aman1919
2 items in carousel
f3ec797 
Signed-off-by: AMAN SINGH <89124765+Aman1919@users.noreply.github.com>
@netlify
Copy link

netlify bot commented Feb 15, 2025 •
edited
Loading

✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!

Name Link
🔨 Latest commit 47aff0d
🔍 Latest deploy log https://app.netlify.com/sites/bejewelled-pegasus-b0ce81/deploys/67d18a806d758100085cd0f6
😎 Deploy Preview https://deploy-preview-446--bejewelled-pegasus-b0ce81.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vishalvivekm
Copy link
Contributor

vishalvivekm commented Feb 24, 2025

@Aman1919
Thank you for your contribution!
Let's discuss this during the website call on Today at 7 AM CT | 6:30 PM IST
adding it as an agenda item to the meeting minutes.

@leecalcote
Copy link
Member

leecalcote commented Feb 27, 2025

@Vidit-Kushwaha will you offer review here?

Vidit-Kushwaha
Vidit-Kushwaha approved these changes Mar 2, 2025
View reviewed changes
Copy link

@Vidit-Kushwaha Vidit-Kushwaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 // Thanks @Aman1919

@leecalcote leecalcote requested a review from vishalvivekm March 3, 2025 21:22
leecalcote
leecalcote requested changes Mar 3, 2025
View reviewed changes
layouts/partials/video-section-related.html
<style>

</style> No newline at end of file
<script>
Copy link
Member

@leecalcote leecalcote Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aman1919 I would much prefer a CSS-only implementation. Can you make this happen?

Copy link
Contributor

@winkletinkle winkletinkle Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aman1919, are you following through on this request?

Copy link
Contributor

@miacycle miacycle Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aman1919 ????

@leecalcote
Copy link
Member

leecalcote commented Mar 4, 2025

@vishalvivekm, please steward this forward.

@github-actions
Copy link

github-actions bot commented Mar 23, 2025

Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.

        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@miacycle
Copy link
Contributor

miacycle commented Apr 21, 2025

@Aman1919, did you give up on this?

@leecalcote
Copy link
Member

leecalcote commented May 20, 2025

@vishalvivekm, please steward this forward.

@vishalvivekm please steward this forward.

@vishalvivekm
Copy link
Contributor

vishalvivekm commented May 21, 2025

fixed by #465

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@winkletinkle winkletinkle winkletinkle left review comments

@miacycle miacycle miacycle left review comments

@leecalcote leecalcote leecalcote requested changes

@vishalvivekm vishalvivekm Awaiting requested review from vishalvivekm

+1 more reviewer

@Vidit-Kushwaha Vidit-Kushwaha Vidit-Kushwaha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component/cloud-docs issue/remind Issue progress check

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[video] more on-screen slides in carousel

6 participants

@Aman1919 @vishalvivekm @leecalcote @miacycle @Vidit-Kushwaha @winkletinkle