-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zone load and HVAC system auto-sizing to Spawn #3866
Comments
@mwetter here are a couple of things to discuss.
|
Regarding 1, the time should be seconds since 0:00 on January 1, or the start of the day if a design day causes the highest load. The associated outdoor conditions are to be reported as shown in the table in section https://lbl-srg.github.io/soep/softwareArchitecture.html#coupling-of-the-envelope-model Regarding 2, zones should have no outdoor air exchange during the sizing; this needs to be added on the Modelica side (as the HVAC model determines whether for example a zone is over-pressurized and has no infiltration). |
For item 1, I believe the, "or the start of the day if a design day causes the highest load" answers my question. Though, I'm still unsure about how this information will be used and if we're giving what is needed. How would someone know if the reported time was offset from January 1st (presumable because design load was driven from the weather file) or alternatively the reported time is offset from one of the design days? I don't see how a client would know, and if they don't then how is the information useful? Another nuance about item 1, is that when sizing from the weather file using SizingPeriod:WeatherFileDays, you still prescribe a specific day in the weather file as the sizing period. Considering this, would we perhaps want to report time from the start of the day, even if that day is one of the days in the weather file? That would bring some consistency to how we are proposing to report time in the case of RunPeriod:DesignDay. On item 2. It seems like we are going to report sizes that are too low if we do not include some kind of ventilation in the sizing run. Is the idea that additional capacity will be added on the Modelica side on top of the load reported by EnergyPlus? |
Here is the Linux build that contains all of the new autosizing variables. We can discuss the details at tomorrow's meeting. https://spawn.s3.us-east-1.amazonaws.com/custom/Spawn-light-0.6.0-5297abe3fb-Linux.tar.gz |
@kbenne : With this binary and the code at 33eaa4d I get a segmentation fault. The output below is from running The suspicious lines are
Dymola also crashes. Can you reproduce this? The json file is below. |
Hi @mwetter. I see it now. Yes there is an exception in my test, but it is caught and the test continues so I didn't notice it. I think I will have a fix tomorrow. |
Update: I owe a comment on this as I was expecting a fix 3 days ago. Sadly this is not an update that comes with a new binary, but (maybe) getting there. The cause of your (@mwetter) particular issue was easy for me to fix and I have, which was that I did not properly account for models that were not fully setup for autosizing. I was expecting certain state to be populated that is not when autosizing is not on. But along the way I've found more issues. Specifically, I'm realizing that I need more of the EnergyPlus model than I realized for this to work properly. Specifically, I need to keep thermostats and zone HVAC connections, even if there is no HVAC. I miight even need some kind of minimal (ideal air loads) system to get the sizing algo to work properly. I suspected this early on during the conceptualization of this feature, but I thought I had avoided these complications, which turns out to not be true. I'm working on sorting it out and will have more to say soon. |
@kbenne : Thanks, appreciate the update. No problem if it takes a bit longer. |
This change will create an ideal air load system for each zone prior to running the EnergyPlus autosizing routine. ref lbl-srg/modelica-buildings#3866
@mwetter can you please take a look at this build? https://spawn.s3.us-east-1.amazonaws.com/custom/Spawn-light-0.6.0-47c6610ff8-Linux.tar.gz Key changes are:
|
|
@kbenne : I still get a segmenation fault by running the same setup and example as in #3866 (comment). The log file of OpenModelica is attached. This is with commit 1a58aee Does this run on your installation? |
Just for our due diligence, can you confirm the md5 for the package you are using is |
I have good test coverage that runs the underlying idf, |
I just rerun it with a clean clone, verified that I have the same hash, and get the same error as reported above. |
Perhaps you can send me the spawn json file that is involved? The paths won't be portable, but I think I will get useful information from it. |
See attached. |
I've determined that the issue is related to the grouping of zones via the |
This issue is to update the Spawn coupling to allow obtaining sizing information for zone HVAC and system HVAC, as described in https://lbl-srg.github.io/soep/softwareArchitecture.html
The implementation on the EnergyPlus side will be done after upgrading to the latest version of EnergyPlus. To progress on the Modelica implementation, it will initially be done in the source code in the package
EnergyPlus_9_6_0
and then moved toEnergyPlus_xxx
after the Spawn binaries and models are updated.The text was updated successfully, but these errors were encountered: