Skip to content

Commit 9894b56

Browse files
committed
fix test
1 parent 25f4a34 commit 9894b56

File tree

5 files changed

+15
-11
lines changed

5 files changed

+15
-11
lines changed

R/walk_pages.R

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -41,13 +41,16 @@ deal_with_empty <- function(return_list, properties, service,
4141
if(service == "daily"){
4242
return_list$time <- as.Date(as.character())
4343
}
44+
45+
return_list <- data.frame(return_list)
46+
return_list$geometry <- NULL
47+
48+
if(!skipGeometry){
49+
return_list <- sf::st_as_sf(return_list, geometry = sf::st_sfc())
50+
}
51+
4452
}
45-
return_list <- data.frame(return_list)
46-
return_list$geometry <- NULL
47-
48-
if(!skipGeometry){
49-
return_list <- sf::st_as_sf(return_list, geometry = sf::st_sfc())
50-
}
53+
5154
return(return_list)
5255
}
5356

tests/testthat/tests_userFriendly_fxns.R

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ test_that("Unit value data returns correct types", {
6868
context("Peak, rating, meas, site")
6969
test_that("peak, rating curves, surface-water measurements", {
7070
testthat::skip_on_cran()
71-
skip_on_ci()
71+
testthat::skip_on_ci()
7272
siteNumbers <- c("01594440", "040851325")
7373
data <- readNWISpeak(siteNumbers)
7474
expect_is(data$agency_cd, "character")
@@ -120,7 +120,8 @@ test_that("peak, rating curves, surface-water measurements", {
120120

121121
test_that("read_waterdata_daily", {
122122
testthat::skip_on_cran()
123-
123+
testthat::skip_on_ci()
124+
124125
siteNumber <- "USGS-04085427"
125126
startDate <- "2012-01-01"
126127
endDate <- "2012-06-30"

tutorials/images/publish.png

81.6 KB
Loading

vignettes/basic_slides.Rmd

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@ editor_options:
1212
chunk_output_type: console
1313
---
1414

15-
Click the slide below then "f" for full screen, and "Esc" to escape full screen.
15+
For a direct link to the slides, go [here](https://doi-usgs.github.io/dataRetrieval/tutorials/basic_slides_deck.html). Use the arrow keys to advance the slides. Or click the slide below then "f" for full screen, and "Esc" to escape full screen.
1616

1717
```{=html}
18-
<iframe src="../tutorials/basic_slides_deck.html" width="700"
18+
<iframe src="../tutorials/basic_slides_deck.html" width="800"
1919
height="400"></iframe>
2020
```
2121

vignettes/changes_slides.Rmd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ editor_options:
1212
chunk_output_type: console
1313
---
1414

15-
Click the slide below then "f" for full screen, and "Esc" to escape full screen.
15+
For a direct link to the slides, go [here](https://doi-usgs.github.io/dataRetrieval/tutorials/changes_slides_deck.html). Use the arrow keys to advance the slides. Or click the slide below then "f" for full screen, and "Esc" to escape full screen.
1616

1717
```{=html}
1818
<iframe src="../tutorials/changes_slides_deck.html" width="700"

0 commit comments

Comments
 (0)