[Bug]: Validation missing for Date Range; End Date can be set before Start Date in Deadline of registration

[kishorprajapati1212]

Description

There is a lack of logical validation in the date selection inputs in Registration in Splash Programs. Currently, the system allows a user to select and save an End Date that chronologically occurs before the Start Date.

Steps to Reproduce

1. Navigate to the ESP manage/Splash/2007/deadlines page.
2. Select a Start Date (e.g., 4/20/2026).
3. Select an End Date that is earlier than the Start Date (e.g., 04/01/2026).
4. Click "Save" or "Submit."

Expected Behavior

The system should trigger a validation error (e.g., "End Date cannot be earlier than Start Date") and prevent the form from being submitted or saved to the database.

Actual Behavior

The system accepts the input and successfully saves the invalid date range without any warnings or errors.

Screenshots

20260420-1312-12.0695370.mp4

Operating System

No response

Browser

No response

Contribution Intent

@willgearty I would like to collaborate with a maintainer or another contributor to fix this.

[github-actions]

👋 Thanks for opening this issue!

To keep the tracker focused, new issues are locked for conversation until a maintainer has reviewed them. This helps us avoid duplicates and ensure issues are actionable.

What happens next:

• A maintainer will review this issue shortly.
• If approved, the conversation will be unlocked and the needs-triage label removed.
• If this is a duplicate or out of scope, a maintainer will close it with an explanation.

Please don't worry — your issue hasn't been rejected, it's just waiting for review. 🙏

[Oval17]

/assign

[github-actions]

✅ @Oval17 has been assigned to this issue. You have 5/5 issue(s) assigned.

📖 Getting Started · Contribution Rules · Code of Conduct

[Oval17]

Lets work on this @kishorprajapati1212

[kishorprajapati1212]

Hey @Oval17 ! Thanks for the ping. I’m just about to start looking into the codebase to find where the Splash deadline validation is handled. I suspect we need to add a check in the clean() method of the form. Let's keep each other posted on what we find!

I’ve done some initial digging into the codebase. The issue seems to be in esp/program/modules/admincore.py. Specifically, the following form classes are missing a clean() method to handle cross-field validation:

1. EditPermissionForm: Handles updating existing deadlines.
2. NewDeadlineForm: Handles creating new deadlines.
3. NewPermissionForm: Handles individual user permissions.

We should implement a clean() method in these classes to check if end_date < start_date and raise a ValidationError if so. Since I'm a bit tight on time, I can help review the logic if you want to take the lead on the implementation and testing!

[Oval17]

Hi @kishorprajapati1212
#5748
Can you review this pr and give inputs.
Thanks