Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded color used for the button hover state #12553

Closed
MisRob opened this issue Aug 11, 2024 · 14 comments
Closed

Remove hardcoded color used for the button hover state #12553

MisRob opened this issue Aug 11, 2024 · 14 comments
Assignees
Labels
DEV: frontend good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome P2 - normal Priority: Nice to have

Comments

@MisRob
Copy link
Member

MisRob commented Aug 11, 2024

🌱 Are you new to the codebase? Welcome! Please see the contributing guidelines.

Blocked by

Summary

After Kolibri Design System provides $darken_ utilities, let's use them to get rid of this hardcoded color

':hover': { 'background-color': '#A81700' },
by applying the most appropriate $darken_ on the base red color color that the button has when it's not in hovered state.

@MisRob MisRob added P2 - normal Priority: Nice to have DEV: frontend help wanted Open source contributors welcome good first issue Self-contained, straightforward, low-complexity labels Aug 11, 2024
@lokesh-sagi125
Copy link
Contributor

hey , can i get assigned to this issue?

@MisRob
Copy link
Member Author

MisRob commented Aug 17, 2024

Hi @lokesh-sagi125, welcome! Thanks for volunteering, we appreciate it.

Before this issue can be worked on, learningequality/kolibri-design-system#726 needs to be resolved, and another contributor is already assigned to learningequality/kolibri-design-system#726.

We welcome you on another issue! There are contributing opportunities in three repositories. See the contributing guidelines including links to issues suitable for contribution for each repository here:

You can also see the list of unassigned "help wanted" or "good first issue" issues across all repositories.

@shivam-daksh
Copy link
Contributor

Hey @MisRob , If I would work on this issue.

@MisRob
Copy link
Member Author

MisRob commented Aug 22, 2024

Hi again @shivam-daksh , assigned, thanks a lot.

In Kolibri, you can use devserver-with-kds command to run Kolibri with your local KDS so you can access your work in learningequality/kolibri-design-system#728.

@Aditya8840
Copy link

Hi @shivam-daksh
I wanted to check if you’re currently working on this issue. If not, I would love to contribute and take it up.

@shivam-daksh
Copy link
Contributor

shivam-daksh commented Aug 30, 2024

Hi @Aditya8840, An issue in #4634 was persisting. That's the reason it took a long delay. I'll work on this issue.

@MisRob
Copy link
Member Author

MisRob commented Aug 30, 2024

Thanks @shivam-daksh and welcome @Aditya8840.

@Aditya8840, there are other contributing opportunities in three repositories. See the contributing guidelines including links to issues suitable for contribution for each repository here:

You can also see the list of unassigned "help wanted" or "good first issue" issues across all repositories.

@shivam-daksh
Copy link
Contributor

Hi @MisRob , I'm getting error while installing dependencies using yarn install. I've attached the log file.
logs.txt

@akolson
Copy link
Member

akolson commented Sep 2, 2024

Hi @shivam-daksh! It appears, from the above, that you encountered some network connectivity issues(or the connection was not stable during the download) while downloading the dependencies. Could you delete the node_modules files and try to reinstall the dependencies again (yarn install)?
Below is a snippet from the attached logs.txt file attached

info There appears to be trouble with your network connection. Retrying...
info There appears to be trouble with your network connection. Retrying...

@shivam-daksh
Copy link
Contributor

shivam-daksh commented Sep 3, 2024

Hi @MisRob and @akolson , the issue is still persisting. I think it is not because of network error. Please check the logs in the end. I've tried with yarn install after deleting node_modules, still faced the same issue.

@MisRob
Copy link
Member Author

MisRob commented Sep 3, 2024

Hi @shivam-daksh, I'm sorry to hear it's troubling.

I wanted to recommend you Volta to manage your node version, however it seems you are already using it, am I right? The node version looks correct.

Did you follow https://kolibri-dev.readthedocs.io/en/develop/getting_started.html closely step by step before running yarn install? To understand whether there was an issue even before running yarn install.

If you haven't done so already, I'd recommend to delete the entire folder and try one more time. If it doesn't help, would you message us at [email protected] to receive Slack invitation and upload as many logs as possible from the whole setup process there?

@shivam-daksh
Copy link
Contributor

shivam-daksh commented Sep 3, 2024

Hi @MisRob,

I'm using Volta to manage my Node versions and followed the instructions from the Kolibri documentation exactly. When I tried this on GitHub Codespaces, the yarn install command completed without errors. However, after running yarn run devserver (or devserver-hot), the build was successful, but when I accessed the project through the forwarded port, I only saw Kolibri's loading screen with the logo. I waited for a while, but Kolibri never fully loaded.

I also tried deleting the entire folder and re-cloning the project on my local system, but I'm encountering the same issue with yarn install.

Any suggestions on how to resolve this?

@MisRob
Copy link
Member Author

MisRob commented Sep 3, 2024

@shivam-daksh Looking at logs, this seems to be something similar? nodejs/node-gyp#2681. Would you try play around with some guidance offered there if so?

@MisRob
Copy link
Member Author

MisRob commented Sep 12, 2024

Closed by #12645

@MisRob MisRob closed this as completed Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: frontend good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome P2 - normal Priority: Nice to have
Projects
None yet
Development

No branches or pull requests

5 participants