-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hardcoded color used for the button hover state #12553
Comments
hey , can i get assigned to this issue? |
Hi @lokesh-sagi125, welcome! Thanks for volunteering, we appreciate it. Before this issue can be worked on, learningequality/kolibri-design-system#726 needs to be resolved, and another contributor is already assigned to learningequality/kolibri-design-system#726. We welcome you on another issue! There are contributing opportunities in three repositories. See the contributing guidelines including links to issues suitable for contribution for each repository here:
You can also see the list of unassigned "help wanted" or "good first issue" issues across all repositories. |
Hey @MisRob , If I would work on this issue. |
Hi again @shivam-daksh , assigned, thanks a lot. In Kolibri, you can use |
Hi @shivam-daksh |
Hi @Aditya8840, An issue in #4634 was persisting. That's the reason it took a long delay. I'll work on this issue. |
Thanks @shivam-daksh and welcome @Aditya8840. @Aditya8840, there are other contributing opportunities in three repositories. See the contributing guidelines including links to issues suitable for contribution for each repository here:
You can also see the list of unassigned "help wanted" or "good first issue" issues across all repositories. |
Hi @shivam-daksh! It appears, from the above, that you encountered some network connectivity issues(or the connection was not stable during the download) while downloading the dependencies. Could you delete the node_modules files and try to reinstall the dependencies again (
|
Hi @shivam-daksh, I'm sorry to hear it's troubling. I wanted to recommend you Volta to manage your node version, however it seems you are already using it, am I right? The node version looks correct. Did you follow https://kolibri-dev.readthedocs.io/en/develop/getting_started.html closely step by step before running If you haven't done so already, I'd recommend to delete the entire folder and try one more time. If it doesn't help, would you message us at [email protected] to receive Slack invitation and upload as many logs as possible from the whole setup process there? |
Hi @MisRob, I'm using Volta to manage my Node versions and followed the instructions from the Kolibri documentation exactly. When I tried this on GitHub Codespaces, the I also tried deleting the entire folder and re-cloning the project on my local system, but I'm encountering the same issue with yarn install. Any suggestions on how to resolve this? |
@shivam-daksh Looking at logs, this seems to be something similar? nodejs/node-gyp#2681. Would you try play around with some guidance offered there if so? |
Closed by #12645 |
🌱 Are you new to the codebase? Welcome! Please see the contributing guidelines.
Blocked by
Summary
After Kolibri Design System provides
$darken_
utilities, let's use them to get rid of this hardcoded colorkolibri/kolibri/plugins/coach/assets/src/views/common/QuizStatus.vue
Line 350 in 7ba25fd
$darken_
on the base red color color that the button has when it's not in hovered state.The text was updated successfully, but these errors were encountered: