Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create temporary routes path where changes will be built for lesson creation and editing #12622

Closed
Tracked by #11888
rtibbles opened this issue Aug 29, 2024 · 0 comments · Fixed by #12672
Closed
Tracked by #11888

Create temporary routes path where changes will be built for lesson creation and editing #12622

rtibbles opened this issue Aug 29, 2024 · 0 comments · Fixed by #12672
Assignees
@nucleogenesis @ozer550
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend P0 - critical Priority: Release blocker or regression
Milestone
Kolibri 0.18: Coa...

Comments

@rtibbles
Copy link
Member

rtibbles commented Aug 29, 2024 •
edited
Loading

A nested route should be created for lesson creation in lessonPlanRoutes.js, any components that do not currently exist should be created as empty wrapper components with an appropriate name property:

  {
    name: PageNames.LESSON_CREATION_ROOT,
    path: '/:classId/plan/lessonstemp/:lessonId/edit',
    component: CreateLessonPage,
    children: [
      {
        name: PageNames.LESSON_EDIT_DETAILS,
        path: 'details/',
        component: EditLessonDetails,
      },
      {
        name: PageNames.LESSON_SELECT_RESOURCES,
        path: 'select-resources/:topicId?',
        component: ResourceSelection,
      },
      {
        name: PageNames.LESSON_PREVIEW_SELECTED_RESOURCES,
        path: 'preview-resources/',
        component: PreviewSelectedResources,
      },
      {
        name: PageNames.LESSON_PREVIEW_RESOURCE,
        path: 'preview-resources/:nodeId',
        component: PreviewSelectedResources,
      },
    ],
  },

The ResourceSelection component should be reused from quiz editing - but may need to be tweaked and conditionalized for the different behaviours for lessons and quizzes - this can be done in follow up work.

Toggling of search display in the LESSON_SELECT_RESOURCES route will be based on whether search terms are active in the query parameters (as is currently handled by the useBaseSearch composable).
@rtibbles rtibbles mentioned this issue Aug 29, 2024
Open
@rtibbles rtibbles changed the title Create temporary routes path where changes will be built for quiz and learn building Create temporary routes path where changes will be built for lesson creation and editing Aug 29, 2024
@rtibbles rtibbles added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend labels Aug 29, 2024
@marcellamaki marcellamaki added the P0 - critical Priority: Release blocker or regression label Sep 10, 2024
@ozer550 ozer550 mentioned this issue Sep 19, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nucleogenesis nucleogenesis

@ozer550 ozer550

Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend P0 - critical Priority: Release blocker or regression
Projects
None yet
Milestone
Kolibri 0.18: Coach Resource Discovery
Development

Successfully merging a pull request may close this issue.

Adds temporary routes for lesson creation and edits ozer550/kolibri
4 participants
@rtibbles @nucleogenesis @marcellamaki @ozer550