Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address cheffing script arguments for deploy and publish #414

Open
bjester opened this issue Apr 12, 2023 · 0 comments
Open

Address cheffing script arguments for deploy and publish #414

bjester opened this issue Apr 12, 2023 · 0 comments

Comments

@bjester
Copy link
Member

bjester commented Apr 12, 2023

  • ricecooker version: develop branch

Summary

It appears that --deploy no longer does anything. It is also a prerequisite for also passing --publish. On Studio, we re-architected how the deploy process functions to utilize change events. Publishing already uses the same change event mechanism. The change event mechanism would require polling of Studio in order to determine if those change events are applied.

Additionally, --deploy maps to stage in the code, and is confusing because there was at one point a --stage arg that is now deprecated and is the default behavior.

Desired behavior

Reviewing a staged channel on Studio before deploying it sounds like the ideal workflow that we want to encourage, but we may wish to keep this ability within ricecooker. That means we either need to:

  • remove the arguments and their functionality, and update the documentation, or
  • update their functionality to function with changes made to Studio, allowing these to process the operations in change events

Reference: learningequality/studio#3997

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant