-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move helpText to LicenseDropdown component #4739
Move helpText to LicenseDropdown component #4739
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM - just one request to add a comment for the hardcoded px value
contentcuration/contentcuration/frontend/shared/views/LicenseDropdown.vue
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LianaHarris360 I tested and tried a couple times to be sure that when I have nodes I've copied from a published & public channel and paste them into a new channel, I don't see the text beneath the inputs for the 4 disabled inputs.
I confirmed the channel I copied from to be public by going to the Administration page and seeing it had the green dot.
Am I maybe not testing out the correct situation?
Hmm, I think maybe you're on the edit details page, the help text does not show on there. But now I'm wondering why the help text displays within the edit source modal but not when trying to edit the source from the edit details page. editSource.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this locally and it LGTM!
Summary
Description of the change(s) you made
This pull request addresses the issue of the overlapping "About Licenses" dropdown button with the text
Cannot edit for public channel resources
by moving thehelpText
to theLicenseDropdown
component as a new parameter.Screenshots (if applicable)
Reviewer guidance
How can a reviewer test these changes?
References
Fixes #4736
Contributor's Checklist
PR process:
CHANGELOG
label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocs
label has been added if this introduces a change that needs to be updated in the user docs?requirements.txt
files also included in this PRStudio-specifc:
notranslate
class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages
,components
, andlayouts
directories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarn
andpip
)